From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D2AED960D for ; Tue, 10 May 2016 11:21:38 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 10 May 2016 02:21:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,604,1455004800"; d="scan'208";a="962534925" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga001.fm.intel.com with ESMTP; 10 May 2016 02:21:13 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.54]) by IRSMSX108.ger.corp.intel.com ([169.254.11.241]) with mapi id 14.03.0248.002; Tue, 10 May 2016 10:21:12 +0100 From: "Mcnamara, John" To: "Gonzalez Monroy, Sergio" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 9/9] doc: update ipsec sample guide Thread-Index: AQHRp7UBjCcJZCZw60qZxcNWS0YdW5+x6p+w Date: Tue, 10 May 2016 09:21:11 +0000 Message-ID: References: <1462552302-5852-1-git-send-email-sergio.gonzalez.monroy@intel.com> <1462552302-5852-10-git-send-email-sergio.gonzalez.monroy@intel.com> In-Reply-To: <1462552302-5852-10-git-send-email-sergio.gonzalez.monroy@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjc1YzY4OWItYWU0ZS00MWFmLWFkODgtOTgwNzYyN2Y3ODg4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ill1c1NzRXg4MDRXOHBjWnNmeWk3R0xJa1F1MUcxaGFmWXpuUnVuZkQ1MGM9In0= x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 9/9] doc: update ipsec sample guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2016 09:21:39 -0000 Hi, Thanks for the updated docs and clear examples. Some minor comments below. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Friday, May 6, 2016 5:32 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 9/9] doc: update ipsec sample guide >=20 > Signed-off-by: Sergio Gonzalez Monroy > --- > doc/guides/sample_app_ug/ipsec_secgw.rst | 583 ++++++++++++++++++++-----= - > ----- > 1 file changed, 381 insertions(+), 202 deletions(-) > +#. [Optional] Build the application for debugging: > + This option adds some extra flags, disables compiler optimizations an= d > + is verbose. > + > + .. code-block:: console > + > + make DEBUG=3D1 > + For simple console code-blocks like this you can just use ::. It defaults to "console". > + > +.. _figure_ipsec_endpoints: > + > +.. figure:: img/ipsec_endpoints.svg > + > + IPSec Inbound/Outbound traffic The patch is missing the file: doc/guides/sample_app_ug/img/ipsec_endpoints.svg > ++-----------------------------------+------------+ > +| **Dst** | **SA idx** | > +| | | > ++-----------------------------------+------------+ > +| 192.168.105.0/24 | 5 | > +| | | You should add the table directive before these tables so that a caption can be applied: .. _table_ipsec_endpoint_outbound_sp: =20 .. table:: Endpoint 0 Outbound Security Policies =20 +-----------------------------------+------------+ | **Dst** | **SA idx** | | | | +-----------------------------------+------------+ | 192.168.105.0/24 | 5 | | | | John