From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5D7BE8D37 for ; Mon, 16 May 2016 15:01:47 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP; 16 May 2016 06:01:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,627,1455004800"; d="scan'208";a="807665303" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga003.jf.intel.com with ESMTP; 16 May 2016 06:01:46 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 16 May 2016 14:01:44 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.54]) by irsmsx112.ger.corp.intel.com ([169.254.1.10]) with mapi id 14.03.0248.002; Mon, 16 May 2016 14:01:44 +0100 From: "Mcnamara, John" To: "Wu, Jingjing" , "david.marchand@6wind.com" CC: "dev@dpdk.org" , "Wu, Jingjing" , "Yang, Ziye" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] doc: known issue on EAL argv Thread-Index: AQHRrNZ7PUAKTnOuEkWZBuaOW6JfWJ+7i8jg Date: Mon, 16 May 2016 13:01:43 +0000 Message-ID: References: <1463116489-31805-1-git-send-email-jingjing.wu@intel.com> In-Reply-To: <1463116489-31805-1-git-send-email-jingjing.wu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjQzNThjNmUtMTQ3Zi00Yjc2LTlhMzItNGZhYmUyNjEzNWNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlA3d1ZcLzh3NzEydG41cEdPdDBoekdHaWV1YWRySVhsbTRHZnU0RzNSNExNPSJ9 x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: known issue on EAL argv X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 May 2016 13:01:47 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jingjing Wu > Sent: Friday, May 13, 2016 6:15 AM > To: david.marchand@6wind.com > Cc: dev@dpdk.org; Wu, Jingjing ; Yang, Ziye > ; Richardson, Bruce > Subject: [dpdk-dev] [PATCH] doc: known issue on EAL argv >=20 > This patch docs the issue on EAL argument that the last EAL argument is > replaced by program name in argv[]. >=20 > Reported-by: Ziye Yang > Signed-off-by: Jingjing Wu Hi Ziye, The title would be better as "doc: add known issue with EAL argv" Also, below are some suggested changes to the docs in the patch: The last EAL argument is replaced by the program name in argv[] --------------------------------------------------------------- **Description**: The last EAL argument is replaced by the program name in ``argv[]`` afte= r ``eal_parse_args()`` is called. This is the intended behavior but it causes the pointer to the last EAL = argument to be lost. **Implication**: If the last EAL argument in ``argv[]`` is generated by a malloc function,= changing it will cause memory issues when freeing the argument. **Resolution/Workaround**: An application should not consider the value in ``argv[]`` as unchanged. **Affected Environment/Platform**: All. **Driver/Module**: Environment Abstraction Layer (EAL).