From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 329F7C134
 for <dev@dpdk.org>; Wed,  8 Jun 2016 19:33:44 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by orsmga101.jf.intel.com with ESMTP; 08 Jun 2016 10:18:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,440,1459839600"; d="scan'208";a="997965522"
Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66])
 by fmsmga002.fm.intel.com with ESMTP; 08 Jun 2016 10:18:42 -0700
Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by
 IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Wed, 8 Jun 2016 18:18:28 +0100
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.240]) by
 IRSMSX156.ger.corp.intel.com ([10.108.20.68]) with mapi id 14.03.0248.002;
 Wed, 8 Jun 2016 18:18:29 +0100
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, "De Lara Guarch, Pablo"
 <pablo.de.lara.guarch@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] testpmd: fix typo when closing port
Thread-Index: AQHRwZltfKd2FNLTkUm7hY+nX+1GA5/fsbIAgAAeSvA=
Date: Wed, 8 Jun 2016 17:18:27 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE20257DD57@IRSMSX103.ger.corp.intel.com>
References: <1465399231-7023-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <43127148.6njRUyVk9W@xps13>
In-Reply-To: <43127148.6njRUyVk9W@xps13>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDZmM2I3MDMtYmM0Yy00YmEyLWE4ZDItYmExNTM1NDVhYTliIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjNRdEQyOHNrV0VHRVVuNzVwUExMaHoyMjB6TTY1RlIxcFM2dHBFekZ3XC9rPSJ9
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH] testpmd: fix typo when closing port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jun 2016 17:33:44 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, June 8, 2016 5:29 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] testpmd: fix typo when closing port
>=20
> 2016-06-08 16:20, Pablo de Lara:
> >  		if (rte_atomic16_cmpset(&(port->port_status),
> >  			RTE_PORT_HANDLING, RTE_PORT_CLOSED) =3D=3D 0)
> > -			printf("Port %d can not be set into stopped\n", pi);
> > +			printf("Port %d can not be set into closed\n", pi);
>=20
> My english would say "Port cannot be closed".
> Am I wrong?

Yes, that is better or "Port cannot be set to closed" if "closed" is a
state like here.