From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 0E550C660 for ; Fri, 24 Jun 2016 17:47:05 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 24 Jun 2016 08:47:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,521,1459839600"; d="scan'208";a="127974987" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga004.fm.intel.com with ESMTP; 24 Jun 2016 08:47:04 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.240]) by IRSMSX101.ger.corp.intel.com ([169.254.1.155]) with mapi id 14.03.0248.002; Fri, 24 Jun 2016 16:47:03 +0100 From: "Mcnamara, John" To: "Xing, Beilei" CC: "dev@dpdk.org" Thread-Topic: [PATCH] examples/l3fwd: update documentation Thread-Index: AQHRzS5fL1yN+dOLmUqQL1VDSCUAj5/4wpoQ Date: Fri, 24 Jun 2016 15:47:02 +0000 Message-ID: References: <1466672695-27041-1-git-send-email-beilei.xing@intel.com> In-Reply-To: <1466672695-27041-1-git-send-email-beilei.xing@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2E4NjE2MTQtZDE0ZC00MGI4LThiOTEtNTc4NmI4OTRmMTU4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImNYWDVWWHMrTkxDTjFKbHF0eWlodG9BbFl5WEExeHBQM2NTSDh3VVR6M2c9In0= x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: update documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2016 15:47:06 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Thursday, June 23, 2016 10:05 AM > To: Mcnamara, John > Cc: dev@dpdk.org; Xing, Beilei > Subject: [PATCH] examples/l3fwd: update documentation >=20 > Update l3fwd documentation with -E, -L and --eth-dest options. >=20 Hi, Thanks for the doc fixes. The usage example just before this should also be updated to add these (and a few other) missing options. Something like: ./l3fwd [EAL options] -- -p PORTMASK [-P] [-E] [-L] --config(port,queue,lcore)[,(port,queue,lcore)= ] [--eth-dest=3DX,MM:MM:MM:MM:MM:MM] [--enable-jumbo] [--max-pkt-len PKTLEN]] [--no-numa] [--hash-entry-num] [--ipv6] [--parse-ptype] > +* -E: enable exact match The options would look better in fixed width quotes: * ``-E:`` Enable exact match. > +* --parse-ptype: optional, set it if use software way to analyze packe= t > type. Without this option, HW will check packet type. Maybe better as: * ``--parse-ptype:`` Optional, set to use software to analyze packet ty= pe. Without this option, hardware will check the packet type. Note, the l3fwd main.c usage should also be updated to add these options and fix missing (and incorrect) options. I'll send you a patch for that and you can integrate it with your changes. John