From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2FEBC5AA1 for ; Sun, 26 Jun 2016 22:04:14 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 26 Jun 2016 13:04:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,533,1459839600"; d="scan'208";a="1005541545" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 26 Jun 2016 13:04:12 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.240]) by IRSMSX101.ger.corp.intel.com ([169.254.1.155]) with mapi id 14.03.0248.002; Sun, 26 Jun 2016 21:04:11 +0100 From: "Mcnamara, John" To: "Zhang, Helin" , "dev@dpdk.org" CC: "Zhang, Helin" Thread-Topic: [dpdk-dev] [PATCH v2 1/2] i40e: fix problematic dereference Thread-Index: AQHRz8H0skv0ss/fd0Gyu+jn02YcPZ/8LDPA Date: Sun, 26 Jun 2016 20:04:10 +0000 Message-ID: References: <1461210177-29330-1-git-send-email-helin.zhang@intel.com> <1466955978-24386-1-git-send-email-helin.zhang@intel.com> <1466955978-24386-2-git-send-email-helin.zhang@intel.com> In-Reply-To: <1466955978-24386-2-git-send-email-helin.zhang@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_PUBLIC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjk3ZjIxOGItNmVkMi00MTc3LWJiNDYtZDc5OWQyODJlNDJiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJmaHNVVXk4a09VTnlVdURFN0FQdmdjMWI5VXdHZ0xpWnNKQkw2dEpnYU9rPSJ9 x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] i40e: fix problematic dereference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2016 20:04:14 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Helin Zhang > Sent: Sunday, June 26, 2016 4:46 PM > To: dev@dpdk.org > Cc: Zhang, Helin > Subject: [dpdk-dev] [PATCH v2 1/2] i40e: fix problematic dereference >=20 > It fixes the issue reported by Coverity of 'Dereference before null > check', by deleting null checks as they are not necessary at all, or move > null checks before where uses it. >=20 > Coverity ID 119267: Dereference before null check. > Coverity ID 13301: Dereference before null check. > Coverity ID 13294: Dereference before null check. > Coverity ID 13299: Dereference before null check. > Coverity ID 13298: Dereference before null check. >=20 > Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage") > Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director") > Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director") > Fixes: 4861cde46116 ("i40e: new poll mode driver") >=20 > Signed-off-by: Helin Zhang Acked-by: John McNamara