From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 232315A53 for ; Mon, 27 Jun 2016 11:11:55 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 27 Jun 2016 02:11:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,536,1459839600"; d="scan'208";a="983938771" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga001.jf.intel.com with ESMTP; 27 Jun 2016 02:11:53 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.240]) by IRSMSX109.ger.corp.intel.com ([169.254.13.193]) with mapi id 14.03.0248.002; Mon, 27 Jun 2016 10:11:52 +0100 From: "Mcnamara, John" To: "Singh, Jasvinder" , "dev@dpdk.org" CC: "Dumitrescu, Cristian" Thread-Topic: [dpdk-dev] [PATCH] ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file Thread-Index: AQHRzXa/NVh1enaEHEOQ3Qs9Ho0diJ/9C+JQ Date: Mon, 27 Jun 2016 09:11:51 +0000 Message-ID: References: <1466704213-127847-1-git-send-email-jasvinder.singh@intel.com> In-Reply-To: <1466704213-127847-1-git-send-email-jasvinder.singh@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDM3MjA0NWQtODNkYy00OTc3LTg1NGUtNDMwZGNkN2UxZmEyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik00SXJhQjQzc2gremZkK0VxV2xuNVdDcGtaZzkrNG5BOFFocmtIUG5vYUk9In0= x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2016 09:11:55 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Thursday, June 23, 2016 6:50 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [dpdk-dev] [PATCH] ip_pipeline: add Python script file for > creating visual diagram of IP pipeline config file >=20 > This commit adds Python script for generating diagram of the application > configuration file. This script requires graphviz package to be installed > on the machine. The input config file is translated to an output file in > DOT syntax, which is then used to create the image file using graphviz. >=20 > To run the script, following command is used; >=20 > ./diagram-generator.py -f >=20 Hi, That is useful tool. The output looks very good. > + if os.system("which dot"): > + print dot_not_found_msg The dot_not_found_msg variable isn't defined. It should be uppercase. Also, it would be worth making the script Python 3 compliant since more and more distros have that as the default. John