From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id C63062C13 for ; Tue, 28 Jun 2016 18:58:27 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 28 Jun 2016 09:58:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,542,1459839600"; d="scan'208";a="1006843358" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga002.jf.intel.com with ESMTP; 28 Jun 2016 09:58:23 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.240]) by irsmsx105.ger.corp.intel.com ([169.254.7.51]) with mapi id 14.03.0248.002; Tue, 28 Jun 2016 17:58:22 +0100 From: "Mcnamara, John" To: "Singh, Jasvinder" , "dev@dpdk.org" CC: "Dumitrescu, Cristian" Thread-Topic: [dpdk-dev] [PATCH v2] ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file Thread-Index: AQHR0VhLi/Wb753m0ECd7TI4jdcCfp//GU/A Date: Tue, 28 Jun 2016 16:58:21 +0000 Message-ID: References: <1466704213-127847-1-git-send-email-jasvinder.singh@intel.com> <1467130945-130512-1-git-send-email-jasvinder.singh@intel.com> In-Reply-To: <1467130945-130512-1-git-send-email-jasvinder.singh@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTViYjk4YWYtZmUyYy00NDJjLWFkNmYtMjIxYWQwMTBlM2E1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRlb284clp4a2lJbkIxOVJhUnVIQjNcL3JVaWduM2pQSk1TQ0FmVU1FSVwvTT0ifQ== x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2016 16:58:28 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jasvinder Singh > Sent: Tuesday, June 28, 2016 5:22 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [dpdk-dev] [PATCH v2] ip_pipeline: add Python script file for > creating visual diagram of IP pipeline config file >=20 > This commit adds Python script for generating diagram of the application > configuration file. This script requires graphviz package to be installed > on the machine. The input config file is translated to an output file in > DOT syntax, which is then used to create the image file using graphviz. >=20 > To run the script, following command is used; >=20 > ./diagram-generator.py -f >=20 > Some optional arguments are as follows: > -h, --help show this help message and exit >=20 > Signed-off-by: Jasvinder Singh > Signed-off-by: Cristian Dumitrescu > Acked-by: Cristian Dumitrescu The subject line is too long: $ scripts/check-git-log.sh=20 Headline too long: ip_pipeline: add Python script file for creating visual diagram of = IP pipeline config file I would suggest something like: ip_pipeline: add script for creating config diagrams =20 The code looks good though, so: Acked-by: John McNamara =20