From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3B0BECE7 for ; Sun, 17 Jul 2016 21:31:21 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP; 17 Jul 2016 12:31:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,380,1464678000"; d="scan'208";a="735626891" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by FMSMGA003.fm.intel.com with ESMTP; 17 Jul 2016 12:31:19 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.204]) by IRSMSX153.ger.corp.intel.com ([169.254.9.105]) with mapi id 14.03.0248.002; Sun, 17 Jul 2016 20:31:18 +0100 From: "Mcnamara, John" To: "Wu, Jingjing" CC: "dev@dpdk.org" , "Liu, Yong" , "Zhang, Helin" Thread-Topic: [PATCH v3] doc: flow bifurcation guide on Linux Thread-Index: AQHR3aZhOhRuFB4e6UKElVMEmpqQKqAdBfxg Date: Sun, 17 Jul 2016 19:31:18 +0000 Message-ID: References: <1466650946-22523-1-git-send-email-jingjing.wu@intel.com> <1468483465-29135-1-git-send-email-jingjing.wu@intel.com> In-Reply-To: <1468483465-29135-1-git-send-email-jingjing.wu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODFmOWNjYWUtZDM2NS00MjlmLWEyOGEtNzA5OGFkZTdmZTFmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1qTCt4ZmlWdlI0NHlGTm04QkFWaE50TWtvNVIxZUUzdVwvdnVDWEdPT2NJPSJ9 x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] doc: flow bifurcation guide on Linux X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jul 2016 19:31:21 -0000 > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, July 14, 2016 9:04 AM > To: Mcnamara, John > Cc: dev@dpdk.org; Wu, Jingjing ; Liu, Yong > ; Zhang, Helin > Subject: [PATCH v3] doc: flow bifurcation guide on Linux >=20 > Flow bifurcation is a mechanism which depends the advanced Ethernet devic= e > to split traffic between queues. It provides the capability to let the > kernel driver and DPDK driver co-exist and take their advantages. > It is achieved by using SRIOV and NIC's advanced filtering. This patch > describes it and adds the user guide on ixgbe and i40 NICs. Hi Jingjing, Thanks for the nice clear document with clear examples and images. Some minor comments below. > +Other than KNI, the SW is just required to device configuration, no > +need to take care of the packet movement during the traffic split. This > +can get more performance with less CPU overhead. It isn't clear here what KNIs involvement is, if any, or why it is differen= t. I'd suggest clarifying if it is important or just omitting otherwise. > +.. _figure_flow_bifurcation_overview: > + > +.. figure:: img/flow_bifurcation_overview.* > + > + Flow Bifucation Overview s/Bifucation/Bifurcation/ Also, I'd suggest using capitalized "Flow Bifurcation" consistently through= out the doc. > + .. code-block:: console > + > + ethtool -K eth1 ntuple on > + ethtool -N eth1 flow-type udp4 src-ip 192.0.2.2 dst-ip > 198.51.100.2 \ > + action $queue_index_in_VF0 > + ethtool -N eth1 flow-type udp4 src-ip 198.51.100.2 dst-ip > 192.0.2.2 \ > + action $queue_index_in_VF1 > + > + where: > + > + * $queue_index_in_PF: [queue index] I don't see '$queue_index_in_PF' used in this example. > +#. Enable and set flow filters: > + > + * L3 VEB filter, route whose dest IP =3D 192.168.50.108 to VF 0's > queue 2. > + > + .. code-block:: console > + > + ethtool -N flow-type ip4 dst-ip 192.168.50.108 \ > + user-def 0xffffffff00000000 action 2 loc 8 > + I think the code-block level is wrong in these sections. I'll send you on some other minor grammatical changes. Thanks, John