From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 049D02BF4 for ; Mon, 18 Jul 2016 15:00:18 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP; 18 Jul 2016 06:00:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,384,1464678000"; d="scan'208";a="141141042" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga004.fm.intel.com with ESMTP; 18 Jul 2016 06:00:17 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.204]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0248.002; Mon, 18 Jul 2016 14:00:14 +0100 From: "Mcnamara, John" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Doherty, Declan" , "Pattan, Reshma" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v2] crypto: fix memory leak Thread-Index: AQHR4PJ8gleasg+kf0eoTft3tZjbKaAeJjgg Date: Mon, 18 Jul 2016 13:00:14 +0000 Message-ID: References: <1468843230-205038-1-git-send-email-pablo.de.lara.guarch@intel.com> <1468846036-228978-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1468846036-228978-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjdjZDliYzMtYjYzOS00ZjIzLWI5MDktYjA2YjBmYzRlYzNiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IitRdTFQRjJ0aURvOVNPT09QYURQNkpYbVZjcGJvMVY0U3djRlJGUTFcL0c4PSJ9 x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] crypto: fix memory leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2016 13:00:19 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Monday, July 18, 2016 1:47 PM > To: dev@dpdk.org > Cc: Doherty, Declan ; Pattan, Reshma > ; De Lara Guarch, Pablo > > Subject: [dpdk-dev] [PATCH v2] crypto: fix memory leak > > ... > > free_kvlist: > - rte_kvargs_free(kvlist); > + if (kvlist !=3D NULL) > + rte_kvargs_free(kvlist); > return ret; The test against NULL isn't required, that is done in rte_kvargs_free() any= way.