From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4A95C2BB9 for ; Tue, 26 Jul 2016 15:49:16 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 26 Jul 2016 06:49:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,425,1464678000"; d="scan'208";a="1002767304" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga001.jf.intel.com with ESMTP; 26 Jul 2016 06:49:14 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.204]) by IRSMSX151.ger.corp.intel.com ([169.254.4.15]) with mapi id 14.03.0248.002; Tue, 26 Jul 2016 14:49:13 +0100 From: "Mcnamara, John" To: "Rao, Nikhil" , "dev@dpdk.org" CC: "thomas.monjalon@6wind.com" , "Rao, Nikhil" Thread-Topic: [dpdk-dev] [PATCH] ethdev: fix documentation for queue start/stop functions Thread-Index: AQHR5ztE8tSbJjxIqU+ZwARIq+ev7KAquUcg Date: Tue, 26 Jul 2016 13:49:12 +0000 Message-ID: References: <1469536600-7099-1-git-send-email-nikhil.rao@intel.com> In-Reply-To: <1469536600-7099-1-git-send-email-nikhil.rao@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGFjYzcwMjAtOWM0Yi00ZmM3LTg4YWQtNzc4ZmVlNTUzODhjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImUwUFF1KzZPbnJHc2M1XC9pcEFqUXlsYWRqODJ6a29Wb2IwWVRZbUFVTmVRPSJ9 x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: fix documentation for queue start/stop functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2016 13:49:16 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Nikhil P Rao > Sent: Tuesday, July 26, 2016 1:37 PM > To: dev@dpdk.org > Cc: thomas.monjalon@6wind.com; Rao, Nikhil > Subject: [dpdk-dev] [PATCH] ethdev: fix documentation for queue start/sto= p > functions >=20 > From: nikhil.rao@intel.com >=20 > Fix documentation for rte_eth_dev_tx/rx_queue_start/stop() functions Hi, Thanks for this. Some comments below. >=20 > Signed-off-by: Nikhil Rao > --- > lib/librte_ether/rte_ethdev.h | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) >=20 > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.= h > index 022733e..d72fab9 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -2039,9 +2039,7 @@ int rte_eth_dev_socket_id(uint8_t port_id); int > rte_eth_dev_is_valid_port(uint8_t port_id); >=20 > /* > - * Allocate mbuf from mempool, setup the DMA physical address > - * and then start RX for specified queue of a port. It is used > - * when rx_deferred_start flag of the specified queue is true. > + * Start specified RX queue of a port. This change, more or less, reverts the change to this description added in= =20 commit 3111eae26e2296ec049e6dfc3c0c522d7b9e1c62. I don't know if "Allocate mbuf from mempool, setup the DMA physical address= " is correct for all pmds so maybe that could be omitted. However, it is=20 probably worth keeping the part about the rx_deferred_start flag. > * > * @param port_id > * The port identifier of the Ethernet device > @@ -2050,7 +2048,7 @@ int rte_eth_dev_is_valid_port(uint8_t port_id); > * The value must be in the range [0, nb_rx_queue - 1] previously > supplied > * to rte_eth_dev_configure(). > * @return > - * - 0: Success, the transmit queue is correctly set up. > + * - 0: Success, the receive queue is enabled. +1 to this and the other changes. John