From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 81F652BD1 for ; Mon, 1 Aug 2016 17:11:24 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 01 Aug 2016 08:11:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,455,1464678000"; d="scan'208";a="857295771" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 01 Aug 2016 08:11:22 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.204]) by IRSMSX152.ger.corp.intel.com ([169.254.6.43]) with mapi id 14.03.0248.002; Mon, 1 Aug 2016 16:11:05 +0100 From: "Mcnamara, John" To: Thomas Monjalon , Christian Ehrhardt CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples: fix unusual-interpreter Thread-Index: AQHR6/BMW5PyAyXqkESVA9WVPgMIrqAz/d4AgAAGQACAAAPMgIAAKYPA Date: Mon, 1 Aug 2016 15:11:04 +0000 Message-ID: References: <1470054511-31217-1-git-send-email-christian.ehrhardt@canonical.com> <2509298.JEBDPBJoPR@xps13> <2698928.TdmtWMiOju@xps13> In-Reply-To: <2698928.TdmtWMiOju@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmQ3NTdkZTAtOGVjMC00ZWFlLThjNzYtYWU4YTg2YzEwZjQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im1hTU9LbWxtUFlKNW5wOTZpRjdLdHdcLzFjWTVYOHZNVFVyMHR3bWpJTE44PSJ9 x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] examples: fix unusual-interpreter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 15:11:24 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, August 1, 2016 2:26 PM > To: Christian Ehrhardt > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples: fix unusual-interpreter >=20 > 2016-08-01 15:12, Christian Ehrhardt: > > On Mon, Aug 1, 2016 at 2:50 PM, Thomas Monjalon > > > > wrote: > > > 2016-08-01 14:28, Christian Ehrhardt: > > > > Due to regular lintian checks in Debian packaging it surfaced that > > > > these two scripts had a space in their #! statement which renders > > > > it to be human, but not shell readable. > > > [...] > > > > -#! /usr/bin/python2 > > > > +#!/usr/bin/python2 > > > > > > I think we can have a space in the shebang (it works with shells I > know). > > > But maybe lintian do not like it (and it is a sufficient reason to > > > accept this trivial patch). > > > > > > However, a better fix would be to run something else than python2, > > > like /usr/bin/env python. > > > > > > Some other python scripts in tools dir may be fixed. > > > > I agree on both changes you suggested, but not being the scripts > > author I wanted to change as few as possible. > > Also thanks for taking it into consideration even if just for lintian > > :-) > > > > If acceptable to you I'd ask to accept this as-is and consider the > > patch a head-up for all script owners to change their headers. >=20 > We can remove the space in every scripts, at least. > Then we can wait a little for the opinion of the script authors to do mor= e > changes. >=20 Hi, The script is Python2/3 compatible so remove the space and change to /usr/b= in/python or similar. John