From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH] drivers: make driver names consistent
Date: Wed, 24 Aug 2016 22:37:53 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE2025CE4E8@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1472077494-164532-1-git-send-email-pablo.de.lara.guarch@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Wednesday, August 24, 2016 11:25 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH] drivers: make driver names consistent
>
> ...
>
> - $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'eth_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained
> + $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'net_pcap0,rx_pcap=/path/to/ file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' -- --port-topology=chained
I know that this is an existing issue but there shouldn't be a space in
"/path/to/ file". Perhaps you could fix that (in a number of places) as part
of this patch. You could probably leave out the "/path/to/" part altogether as
it may be clearer, see below.
Also, could you wrap the long code lines in the sections that you change at
80 chars using "\" to keep them on the page in the PDF docs, like:
$RTE_TARGET/app/testpmd -c '0xf' -n 4 \
--vdev 'net_pcap0,rx_pcap=/path/to/file_rx.pcap,tx_pcap=/path/to/file_tx.pcap' \
-- --port-topology=chained
Or without the path part:
$RTE_TARGET/app/testpmd -c '0xf' -n 4 \
--vdev 'net_pcap0,rx_pcap=file_rx.pcap,tx_pcap=file_tx.pcap' \
-- --port-topology=chained
John
next prev parent reply other threads:[~2016-08-24 22:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 22:24 Pablo de Lara
2016-08-24 22:27 ` De Lara Guarch, Pablo
2016-08-24 22:37 ` Mcnamara, John [this message]
2016-09-16 9:58 ` Thomas Monjalon
2016-10-18 12:50 ` Jan Blunck
2016-10-18 13:06 ` Yuanhan Liu
2016-10-18 13:42 ` Thomas Monjalon
2016-10-18 14:18 ` Yuanhan Liu
2016-10-18 16:46 ` Thomas Monjalon
2016-10-19 10:05 ` Yuanhan Liu
2016-10-19 12:26 ` Thomas Monjalon
2016-10-18 15:26 ` Jan Blunck
2016-10-18 16:45 ` Thomas Monjalon
2016-10-19 13:32 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE2025CE4E8@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).