From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 9448F58F1 for ; Thu, 25 Aug 2016 00:37:56 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 24 Aug 2016 15:37:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,572,1464678000"; d="scan'208";a="1019872645" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga001.jf.intel.com with ESMTP; 24 Aug 2016 15:37:55 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.204]) by IRSMSX152.ger.corp.intel.com ([169.254.6.43]) with mapi id 14.03.0248.002; Wed, 24 Aug 2016 23:37:54 +0100 From: "Mcnamara, John" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH] drivers: make driver names consistent Thread-Index: AQHR/lZETgV9huq/gU2MVntNSPbLOaBYsQzw Date: Wed, 24 Aug 2016 22:37:53 +0000 Message-ID: References: <1472077494-164532-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1472077494-164532-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODVkMTk4ZmQtNGQ2ZS00M2RiLTkzOGEtODhlM2IzYzhiYWVlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImNTY0ZZRFZ1SHluVTMwak1oMllFTDJDT1o3RXYzaTYrK0ZUbUpVbDk0R0U9In0= x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] drivers: make driver names consistent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2016 22:37:57 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Wednesday, August 24, 2016 11:25 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH] drivers: make driver names consistent > > ... > > - $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'eth_pcap0,rx_pcap=3D/p= ath/to/ file_rx.pcap,tx_pcap=3D/path/to/file_tx.pcap' -- --port-topology=3D= chained > + $RTE_TARGET/app/testpmd -c '0xf' -n 4 --vdev 'net_pcap0,rx_pcap=3D/p= ath/to/ file_rx.pcap,tx_pcap=3D/path/to/file_tx.pcap' -- --port-topology=3D= chained I know that this is an existing issue but there shouldn't be a space in "/path/to/ file". Perhaps you could fix that (in a number of places) as par= t of this patch. You could probably leave out the "/path/to/" part altogether= as=20 it may be clearer, see below. Also, could you wrap the long code lines in the sections that you change at= =20 80 chars using "\" to keep them on the page in the PDF docs, like: $RTE_TARGET/app/testpmd -c '0xf' -n 4 \ --vdev 'net_pcap0,rx_pcap=3D/path/to/file_rx.pcap,tx_pcap=3D/path/t= o/file_tx.pcap' \ -- --port-topology=3Dchained Or without the path part: $RTE_TARGET/app/testpmd -c '0xf' -n 4 \ --vdev 'net_pcap0,rx_pcap=3Dfile_rx.pcap,tx_pcap=3Dfile_tx.pcap' \ -- --port-topology=3Dchained John