From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2D85D2B84 for ; Wed, 28 Sep 2016 18:59:19 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 28 Sep 2016 09:59:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,410,1470726000"; d="scan'208";a="1057846209" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga002.jf.intel.com with ESMTP; 28 Sep 2016 09:59:05 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX107.ger.corp.intel.com (163.33.3.99) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 28 Sep 2016 17:59:04 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.91]) by irsmsx155.ger.corp.intel.com ([169.254.14.133]) with mapi id 14.03.0248.002; Wed, 28 Sep 2016 17:59:04 +0100 From: "Mcnamara, John" To: Thomas Monjalon , "Loftus, Ciara" CC: "dev@dpdk.org" , "Liu, Yuanhan" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id. Thread-Index: AQHSDdEH7RXuyIT9hE2Kc7SF3qACiKCPNLbA Date: Wed, 28 Sep 2016 16:59:03 +0000 Message-ID: References: <1473774463-26966-1-git-send-email-ciara.loftus@intel.com> <28342659.xFrdpVFeBf@xps13> In-Reply-To: <28342659.xFrdpVFeBf@xps13> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_PUBLIC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTQxYWJiNzktMzJmYi00Y2E2LTg0MGMtNTJmZjM1ZmY4YzAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJZaDlRSWxBVm5aNkZpSUF3RHd4U3hNc0RDTTd4bE1yRzVVN0ZGcTgwejFZPSJ9 x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2016 16:59:19 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, September 13, 2016 4:10 PM > To: Loftus, Ciara > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/vhost: Add function to retreive the > 'vid' for a given port id. >=20 > 2016-09-13 14:47, Ciara Loftus: > > In some cases when using the vHost PMD, certain vHost library > > functions may still need to be accessed. One such example is the > > rte_vhost_get_queue_num function which returns the number of > > virtqueues reported by the guest - information which is not exposed by > the PMD. > > > > This commit introduces a new rte_eth_vhost function that returns the > > 'vid' associated with a given port id. This allows the PMD user to > > call vHost library functions which require the 'vid' value. >=20 > I think we should not add any API to the PMDs. > Maybe you are looking for a generic API in ethdev. Hi, This patch got a little lost in a general discussion on generic versus spec= ific APIs. As far as I can see this is a PMD specific API and the general consensus by= the end of the thread was that this would be acceptable. Is that the case = or are there still objections to this patch. The patch is critical for integration of the Vhost PMD into OvS so I'd like= to make sure that we consider it as such. See the discussion here: http://openvswitch.org/pipermail/dev/2016-August/076887.html John=20