From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AB8D02906 for ; Mon, 10 Oct 2016 16:16:12 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 10 Oct 2016 07:16:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,324,1473145200"; d="scan'208";a="1062821351" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga002.jf.intel.com with ESMTP; 10 Oct 2016 07:16:11 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.91]) by IRSMSX102.ger.corp.intel.com ([169.254.2.198]) with mapi id 14.03.0248.002; Mon, 10 Oct 2016 15:16:10 +0100 From: "Mcnamara, John" To: John Daley , "Richardson, Bruce" CC: "dev@dpdk.org" , Nelson Escobar Thread-Topic: [dpdk-dev] [PATCH] net/enic: update enic guide and add warning for invalid conf Thread-Index: AQHSGpPNtCyPQED8jEa/dAOMUXxmsKChywYA Date: Mon, 10 Oct 2016 14:16:09 +0000 Message-ID: References: <20160929205505.31690-1-johndale@cisco.com> In-Reply-To: <20160929205505.31690-1-johndale@cisco.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_PUBLIC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjI3MmVkZGMtMjE1NC00ZWNiLWJkMzctNGZlNGJmYjA2NWUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiIwdkhsaTU2U3R2SFQwNklWVzEwRzJzUzBkZUIwcEZ1TmZBVXduUU1aZXdRPSJ9 x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/enic: update enic guide and add warning for invalid conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 14:16:13 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Daley > Sent: Thursday, September 29, 2016 9:55 PM > To: Richardson, Bruce > Cc: dev@dpdk.org; Nelson Escobar > Subject: [dpdk-dev] [PATCH] net/enic: update enic guide and add warning > for invalid conf >=20 > From: Nelson Escobar >=20 > Update the enic guide to better explain how to setup vNIC parameters on > the Cisco VIC since the introduction of rx scatter and print an error > message for the case of having 1 RQ configured in the vNIC. >=20 > Signed-off-by: Nelson Escobar Hi, It would be better in the RST documentation to use ```` backticks to designate function and variable names as fixed width. Also, the documentati= on convention is to use Rx/Tx. However, these are minor so the patch is okay a= s it is. Acked-by: John McNamara