From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 726DB1E29 for ; Wed, 2 Nov 2016 10:07:51 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP; 02 Nov 2016 02:07:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,583,1473145200"; d="scan'208";a="1053965607" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by orsmga001.jf.intel.com with ESMTP; 02 Nov 2016 02:07:50 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by IRSMSX108.ger.corp.intel.com (163.33.3.3) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 2 Nov 2016 09:07:48 +0000 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.190]) by irsmsx112.ger.corp.intel.com ([169.254.1.102]) with mapi id 14.03.0248.002; Wed, 2 Nov 2016 09:07:48 +0000 From: "Mcnamara, John" To: "Dai, Wei" , Thomas Monjalon , "Ananyev, Konstantin" , "Wu, Jingjing" , "Zhang, Helin" , "Curran, Greg" , "Horton, Remy" , "Van Haaren, Harry" Thread-Topic: [dpdk-dev] [PATCH] ethdev: fix statistics description Thread-Index: AQHR/4HtBAhiY7za2UaM5nZuXc9dWaCYNT+AgC2R9ICAAAlwkA== Date: Wed, 2 Nov 2016 09:07:47 +0000 Message-ID: References: <1472206104-22035-1-git-send-email-wei.dai@intel.com> <2544827.v0ahXV4zxG@xps13> <49759EB36A64CF4892C1AFEC9231E8D63A2EB13C@PGSMSX106.gar.corp.intel.com> In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A2EB13C@PGSMSX106.gar.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDE3MmYwYzYtN2EyYy00YWNlLWExNDQtYjljOTlkNzk0NTFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjhwVlY5Q2ZWU1N0SFN6emVCbU56SndaeWo1SHR2MlNjaUNhTXRTbWZRYUk9In0= x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix statistics description X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 09:07:51 -0000 > -----Original Message----- > From: Dai, Wei > Sent: Wednesday, November 2, 2016 8:29 AM > To: Thomas Monjalon ; Mcnamara, John > ; Ananyev, Konstantin > ; Wu, Jingjing ; > Zhang, Helin ; Dai, Wei ; > Curran, Greg > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] ethdev: fix statistics description >=20 > Hi, John & Greg >=20 > Would you please give any opinion for this patch ? >=20 > I have looked through all PMDs and found not all statistics items can be > supported by some NIC. > For example, rx_nombuf, q_ipackets, q_opackets, q_ibytes and q_obytes > are not supported by i40e. > But when the function rte_eth_stats_get(uint8_t port_id, struct > rte_eth_stats *stats) is called for i40e PMD, Above un-supported > statistics item in output stats are zero, this is not real value. > So far, there is no way to know whether an item in struct rte_eth_stats i= s > supported or not only from this structure definition. > Maybe some structure member can be added to indicate each of statistics > item valid or not. > But this means ABI change. >=20 > In following list, I list statistics support details of all PMDs. > Hope it can be displayed in your screen. Hi, Thanks for the analysis. Perhaps we could an API that returns a struct, or otherwise, that indicated= what stats are returned by a PMD. An application that required stats could= call it once to establish what stats were available. It would have to be d= one in some way that wouldn't break ABI every time a new stat was added. Harry, Remy, how would this fit in with the existing stats scheme or the ne= w metrics library. John