From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 97F9458DB
 for <dev@dpdk.org>; Fri,  2 Dec 2016 11:55:51 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga105.fm.intel.com with ESMTP; 02 Dec 2016 02:55:50 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,729,1477983600"; d="scan'208";a="38226216"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by fmsmga006.fm.intel.com with ESMTP; 02 Dec 2016 02:55:50 -0800
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.91]) by
 IRSMSX153.ger.corp.intel.com ([169.254.9.203]) with mapi id 14.03.0248.002;
 Fri, 2 Dec 2016 10:55:48 +0000
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: unify help strings
Thread-Index: AQHSTD+zcm4wYCy2ykCXWd4+htFdaqD0eWPQ
Date: Fri, 2 Dec 2016 10:55:48 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE20266D23D@IRSMSX103.ger.corp.intel.com>
References: <20161202013727.2117-1-ferruh.yigit@intel.com>
 <20161202015845.7121-1-ferruh.yigit@intel.com>
In-Reply-To: <20161202015845.7121-1-ferruh.yigit@intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_PUBLIC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzY0ZjM5M2UtODU2MS00ZTU5LTljNWQtY2U0NmRlMTI2ODcyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJub2FtSXBob3ZrSkZTZzNwWWxXV0JURG5JY0ZNa3NmSkhMS1FoRkd4aTdjPSJ9
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: unify help strings
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Dec 2016 10:55:52 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Friday, December 2, 2016 1:59 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: unify help strings
>=20
> Formatted as:
> cmd fixed_string fixed|string|options <variable>: Description
>=20
> If there is no description, final colon emitted.
>=20
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>


Good refactoring work to give consistency. It might be worth having a look =
at the testpmd docs to see if some of the same improvements can be made the=
re as well. That could be a separate patch.

>  	.f =3D cmd_config_rss_hash_key_parsed,
>  	.data =3D NULL,
> -	.help_str =3D
> -		"port config X rss-hash-key ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|"
> -		"ipv4-sctp|ipv4-other|ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|"
> -		"ipv6-sctp|ipv6-other|l2-payload|"
> -		"ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex "
> -		"<string of hexa digits (variable length, NIC dependent)>\n",
> +	.help_str =3D "port config <port_id> rss-hash-key "
> +		"ipv4|ipv4-frag|ipv4-tcp|ipv4-udp|ipv4-sctp|ipv4-other|"
> +		"ipv6|ipv6-frag|ipv6-tcp|ipv6-udp|ipv6-sctp|ipv6-other|"
> +		"l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex "
> +		"<string of hexa digits (variable length, NIC dependent)>",

/hex/hexa/

Apart from that:

Acked-by: John McNamara <john.mcnamara@intel.com>