From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 528182934
 for <dev@dpdk.org>; Wed,  7 Dec 2016 13:00:51 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga105.fm.intel.com with ESMTP; 07 Dec 2016 04:00:51 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="14838308"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by orsmga002.jf.intel.com with ESMTP; 07 Dec 2016 04:00:50 -0800
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.91]) by
 IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0248.002;
 Wed, 7 Dec 2016 12:00:49 +0000
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Kulasek, TomaszX"
 <tomaszx.kulasek@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum
 engine
Thread-Index: AQHSUHsW+sVu2EefkUygNM0VZqiwG6D8Ye3w
Date: Wed, 7 Dec 2016 12:00:48 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE20267036C@IRSMSX103.ger.corp.intel.com>
References: <1477486575-25148-1-git-send-email-tomaszx.kulasek@intel.com>
 <1479922585-8640-1-git-send-email-tomaszx.kulasek@intel.com>
 <1479922585-8640-7-git-send-email-tomaszx.kulasek@intel.com>
 <067ddc1b-5b28-47fe-8947-84a218357488@intel.com>
In-Reply-To: <067ddc1b-5b28-47fe-8947-84a218357488@intel.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTFjZjhkN2ItNzdiOS00MThmLWI2YTItYTY2MDg0MjcwNzdhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkVmTFRNWTc4Q2IremIxTGo0QSsyMTNReURJQzFkMndybHZIVXNncStNNjg9In0=
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum
 engine
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Dec 2016 12:00:52 -0000

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Wednesday, December 7, 2016 11:14 AM
> To: Kulasek, TomaszX <tomaszx.kulasek@intel.com>; dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>;
> olivier.matz@6wind.com
> Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in
> csum engine
>=20
> ...
> <...>
> > +cmdline_parse_inst_t cmd_csum_txprep =3D {
> > +	.f =3D cmd_csum_txprep_parsed,
> > +	.data =3D NULL,
> > +	.help_str =3D "enable/disable tx preparation path for csum engine: "
> > +	"csum txprep on|off",
>=20
> Can you please format help string as:
> "cmd fixed_string fixed|string|options <variable>: Description"
> see commit 26faac80327f
>=20
> above becomes:
> "csum txprep on|off: Enable/Disable tx preparation path for csum engine"
>=20


Also, does this require an update to the testpmd docs?

=20