From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 86992F91F for ; Fri, 13 Jan 2017 14:50:16 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP; 13 Jan 2017 04:23:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,221,1477983600"; d="scan'208";a="808434854" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by FMSMGA003.fm.intel.com with ESMTP; 13 Jan 2017 04:23:08 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.77]) by IRSMSX109.ger.corp.intel.com ([169.254.13.44]) with mapi id 14.03.0248.002; Fri, 13 Jan 2017 12:23:07 +0000 From: "Mcnamara, John" To: Jerin Jacob , "Yigit, Ferruh" CC: "dev@dpdk.org" , "thomas.monjalon@6wind.com" Thread-Topic: [dpdk-dev] [PATCH] tools: add tags and cscope index file generation support Thread-Index: AQHSbN8EDDf+XKEBhkS0aqIuTFrsAqE1tb8AgACe5BA= Date: Fri, 13 Jan 2017 12:23:07 +0000 Message-ID: References: <1480205562-32745-1-git-send-email-jerin.jacob@caviumnetworks.com> <204efa1f-0631-ed9c-3d68-8c573edfbb76@intel.com> <20170113025005.GA2951@localhost.localdomain> In-Reply-To: <20170113025005.GA2951@localhost.localdomain> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_PUBLIC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWQxMTU3NGEtYzA5Ny00MjliLWIzZTItNGZmMWIxNDIyODU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJLcGUxMk1pMUppWjJPMmlnQ3puMW5rT0gxVFwvS2hUYjhod3BBTTdxQ1JNND0ifQ== x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] tools: add tags and cscope index file generation support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 13:50:16 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob > Sent: Friday, January 13, 2017 2:50 AM > To: Yigit, Ferruh > Cc: dev@dpdk.org; thomas.monjalon@6wind.com > Subject: Re: [dpdk-dev] [PATCH] tools: add tags and cscope index file > generation support >=20 > On Thu, Jan 12, 2017 at 02:19:44PM +0000, Ferruh Yigit wrote: > > On 11/27/2016 12:12 AM, Jerin Jacob wrote: > > > This script generates cscope, gtags, and tags index files based on > > > EAL environment. > > > (architecture and OS(linux/bsd)) > > > > > > Selection of the architecture and OS environment is based on dpdk > > > configuration target(T=3D) > > > > > > example usage: > > > make tags T=3Dx86_64-native-linuxapp-gcc make cscope > > > T=3Dx86_64-native-linuxapp-gcc make gtags T=3Dx86_64-native-linuxapp-= gcc > > > > > > Signed-off-by: Jerin Jacob > > > > <...> > > > > > + > > > +if [ -n "$T" ]; then > > <...> > > > + usage $1 > > > + exit > > > > I would prefer fallback to RTE_TARGET parsing, or processing all files > > ( cscope -Rqn ), instead of exiting here, but that is your call. >=20 > I would prefer avoid any fallback(sometimes RTE_TARGET can be "build" > also) and print the usage and exit error if the requirements are not meet= . >=20 > > > > > > Also "tags.sh" needs to be moved into "devtools" after latest updates. >=20 > Sure. I will send v2 to address this. Very handy. +1. Could you also add an etags target, for Emacs. Either separately like the=20 gtags target or just add it to the tags target: =20 doetags() { all_sources | xargs etags -a } =20 # or: doctags() { all_sources | xargs ctags -a all_sources | xargs etags -a } It create a TAGS file which should be added to the gitignore rules. Thanks, John