From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3BFBB1396 for ; Thu, 23 Mar 2017 09:41:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490258516; x=1521794516; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DWBrItQyr2VJm3t1RbelrTSyaNctq7EsQCCXUU84LNc=; b=R/tEA0oGL53FGwtfVHxCkpNYHgd0AaAptlqwWyRPowp7dxtTDK8nG73u 7rGaoSQgTQ5J2LA+Ub01FBkH6CeBMQ==; Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Mar 2017 01:41:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,208,1486454400"; d="scan'208";a="79732598" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by fmsmga005.fm.intel.com with ESMTP; 23 Mar 2017 01:41:54 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX153.ger.corp.intel.com (163.33.192.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 23 Mar 2017 08:41:53 +0000 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.107]) by irsmsx155.ger.corp.intel.com ([169.254.14.204]) with mapi id 14.03.0248.002; Thu, 23 Mar 2017 08:41:53 +0000 From: "Mcnamara, John" To: "De Lara Guarch, Pablo" CC: "Trahe, Fiona" , "dev@dpdk.org" Thread-Topic: [PATCH] doc: reformat crypto drivers overview Thread-Index: AQHSoyeOdHCn9ScvYkyCNlCVGRJIiqGiG2XA Date: Thu, 23 Mar 2017 08:41:53 +0000 Message-ID: References: <1490199328-12165-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1490199328-12165-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmY4YmI0ODAtMmMyNC00YzdhLWJkYWMtOTNhYzlkZjJjZmExIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjFKaHAzVXhybUZkQTQwMlBXUVdBeE41eGdZaWhPVFpBZm4rWVVqMTF4XC9RPSJ9 x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: reformat crypto drivers overview X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 08:41:56 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Wednesday, March 22, 2017 4:15 PM > To: Mcnamara, John > Cc: Trahe, Fiona ; dev@dpdk.org; De Lara Guarch, > Pablo > Subject: [PATCH] doc: reformat crypto drivers overview >=20 > Follow the approach in the network devices overview, for the feature > matrix, so it improves readibility and maintainability. >=20 There are pep8 warnings that should be fixed. Mainly for long lines: $ pep8 doc/guides/conf.py =20 doc/guides/conf.py:318:80: E501 line too long (109 > 79 characters) doc/guides/conf.py:320:80: E501 line too long (105 > 79 characters) doc/guides/conf.py:321:80: E501 line too long (81 > 79 characters) doc/guides/conf.py:322:80: E501 line too long (108 > 79 characters) doc/guides/conf.py:324:80: E501 line too long (122 > 79 characters) doc/guides/conf.py:326:80: E501 line too long (102 > 79 characters) Apart from that it is a good change and a nice generalization of the table building approach. With the above fixed: Acked-by: John McNamara