From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4EED22986 for ; Thu, 13 Apr 2017 12:52:07 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2017 03:52:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,194,1488873600"; d="scan'208";a="76911414" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga004.jf.intel.com with ESMTP; 13 Apr 2017 03:52:06 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.241]) by IRSMSX102.ger.corp.intel.com ([169.254.2.153]) with mapi id 14.03.0319.002; Thu, 13 Apr 2017 11:52:05 +0100 From: "Mcnamara, John" To: "Jastrzebski, MichalX K" , "dev@dpdk.org" CC: "Jain, Deepak K" , "Van Haaren, Harry" , "Piasecki, JacekX" , "Kozak, KubaX" , "Kulasek, TomaszX" Thread-Topic: [dpdk-dev] [PATCH v5 1/3] ethdev: new xstats API add retrieving by ID Thread-Index: AQHSsuKGzIeEZJRjGESt44bg5YWVp6HDIRRA Date: Thu, 13 Apr 2017 10:52:04 +0000 Message-ID: References: <1491847180-24784-2-git-send-email-jacekx.piasecki@intel.com> <1491928644-10383-1-git-send-email-michalx.k.jastrzebski@intel.com> <1491928644-10383-2-git-send-email-michalx.k.jastrzebski@intel.com> In-Reply-To: <1491928644-10383-2-git-send-email-michalx.k.jastrzebski@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzc4YjNkZWQtYWM5Yy00MWJjLWI5MmMtYzNlOGRiMjcyOGQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjdTU2tWdXk2TEZhbFRmaERKNDdVOFluWFp5OUFYY05rQjN3OVVud0ZHSGs9In0= dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new xstats API add retrieving by ID X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 10:52:08 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michal Jastrzebski > Sent: Tuesday, April 11, 2017 5:37 PM > To: dev@dpdk.org > Cc: Jain, Deepak K ; Van Haaren, Harry > ; Piasecki, JacekX > ; Kozak, KubaX ; > Kulasek, TomaszX > Subject: [dpdk-dev] [PATCH v5 1/3] ethdev: new xstats API add retrieving > by ID >=20 > From: Jacek Piasecki >=20 > ... > > +Scheme for Human Readable Names > +_______________________________ >=20 > A naming scheme exists for the strings exposed to clients of the API. > This is to allow scraping of the API for statistics of interest. The > naming scheme uses @@ -363,8 +359,8 @@ strings split by a single Minor request, if you are updating this patchset could you use a different title underline than ____. The guidelines suggest: Level 1 Heading =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Level 2 Heading --------------- Level 3 Heading ~~~~~~~~~~~~~~~ Level 4 Heading ^^^^^^^^^^^^^^^ http://dpdk.org/doc/guides/contributing/documentation.html#section-headers So in this case it should probably be ^^^^^^^^^^. However, that is fairly minor and it is okay as is if you don't get to it. John