From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id D5E3D2B9B for ; Mon, 24 Apr 2017 17:49:06 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP; 24 Apr 2017 08:49:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,245,1488873600"; d="scan'208";a="78216292" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga002.jf.intel.com with ESMTP; 24 Apr 2017 08:49:04 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.241]) by IRSMSX153.ger.corp.intel.com ([163.33.192.75]) with mapi id 14.03.0319.002; Mon, 24 Apr 2017 16:49:03 +0100 From: "Mcnamara, John" To: Thomas Monjalon , "Kozak, KubaX" CC: "dev@dpdk.org" , Olivier Matz , "Van Haaren, Harry" , "Jain, Deepak K" , "Piasecki, JacekX" Thread-Topic: [dpdk-dev] [PATCH v6 0/5] Extended xstats API in ethdev library to allow grouping of stats Thread-Index: AQHSvPgkZvKg8mJaV0SiYhCL1XdyVKHUqbTA Date: Mon, 24 Apr 2017 15:49:02 +0000 Message-ID: References: <1491928644-10383-2-git-send-email-michalx.k.jastrzebski@intel.com> <2191902.oqd7qsnxNQ@xps> <20170424143211.3e7db919@platinum> <23329330.ZWGR8gsYE6@xps> In-Reply-To: <23329330.ZWGR8gsYE6@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMWQxYWU1NjQtNzkzOC00NTAwLWEyZjMtNzkxNDlmM2M4ZWY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRrTzA2bkNKZThUa0xaalRZK25hNE1KRVJuVDFLSUNTQ1RRcjVpeTAyTVE9In0= dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 0/5] Extended xstats API in ethdev library to allow grouping of stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Apr 2017 15:49:07 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Monday, April 24, 2017 1:41 PM > To: Kozak, KubaX > Cc: dev@dpdk.org; Olivier Matz ; Van Haaren, Harr= y > ; Jain, Deepak K ; > Piasecki, JacekX > Subject: Re: [dpdk-dev] [PATCH v6 0/5] Extended xstats API in ethdev > library to allow grouping of stats >=20 > 24/04/2017 14:32, Olivier Matz: > > Hi, > > > ... > > So, I wonder if it wouldn't be more simple to keep the old API intact > > (it would avoid unannounced breakage). The new feature can be > > implemented in an additional API: > > > > rte_eth_xstats_get_by_id(uint8_t port_id, const uint64_t *ids, > > uint64_t *values, unsigned int size) > > rte_eth_xstats_get_names_by_id(uint8_t port_id, const uint64_t *ids, > > struct rte_eth_xstat_name *xstats_names, unsigned int size) > > > > Or: > > > > rte_eth_xstats_get_by_id(uint8_t port_id, const uint64_t *ids, > > struct rte_eth_xstat *values, unsigned int size) > > rte_eth_xstats_get_names_by_id(uint8_t port_id, const uint64_t *ids, > > struct rte_eth_xstat_name *xstats_names, unsigned int size) > > > > (which would allow to deprecate the old API, but I'm not sure > > we need to) > > > > > > Can we fix that for 17.05? >=20 > ... >=20 > Back to the issues, please try to fix it quickly or we should revert it > for 17.05-rc3. Hi, We'll submit a patch to change the APIs for rte_eth_xstats_get() and=20 rte_eth_xstats_get_names() back to their previous signature, without symbol versions, and add the APIs suggested by Olivier. We'll work on that as soon as possible. John=20