From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] dpdk: remove typos using codespell utility
Date: Wed, 7 Jun 2017 09:20:37 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23ECEB4CD@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20170607050506.31012-1-jerin.jacob@caviumnetworks.com>
> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Wednesday, June 7, 2017 6:05 AM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Mcnamara, John <john.mcnamara@intel.com>; Jerin
> Jacob <jerin.jacob@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] dpdk: remove typos using codespell utility
>
> Fixing typos across dpdk source code using codespell utility.
> Skipped the ethdev driver's base code fixes to keep the base
> code intact.
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Good work. More people should run spell checks on their code. It is an easy fix
that improves the overall quality.
Note the uses of "iff", which are corrected to "if", are probable correct in
the sense of "iff = if and only if": https://en.wikipedia.org/wiki/If_and_only_if
However, unless mathematical logicians turn up to object it is fine to change it. :-)
Acked-by: John McNamara <john.mcnamara@intel.com>
next prev parent reply other threads:[~2017-06-07 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 5:05 Jerin Jacob
2017-06-07 9:20 ` Mcnamara, John [this message]
2017-06-14 21:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23ECEB4CD@IRSMSX104.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).