From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix a typo in eth device API doc
Date: Sun, 2 Jul 2017 19:19:20 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23ED1DE40@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <9396121.kvQzYzBiED@xps>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Sunday, July 2, 2017 6:49 PM
> To: Mcnamara, John <john.mcnamara@intel.com>
> Cc: dev@dpdk.org; Rao, Nikhil <nikhil.rao@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix a typo in eth device API doc
>
> 30/06/2017 16:47, Mcnamara, John:
> > >
> > > This patch fixes a typo in the eth device API doc, device config.
> > > not stored between calls to rte_eth_dev_start/stop() should be
> > > restored before a call to rte_eth_dev_start() instead of after a
> > > call to rte_eth_dev_start().
> > >
> > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> >
> > Acked-by: John McNamara <john.mcnamara@intel.com>
>
> I am still not convinced by this whole text, but applied to move forward.
Agreed. We should mark this as a defect and have someone re-evaluate the
overall text. However, in terms of this patch, at least it is less wrong than
the existing text.
prev parent reply other threads:[~2017-07-02 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 5:49 Nikhil Rao
2016-08-24 16:06 ` Thomas Monjalon
2017-06-30 14:47 ` Mcnamara, John
2017-07-02 17:49 ` Thomas Monjalon
2017-07-02 19:19 ` Mcnamara, John [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23ED1DE40@IRSMSX104.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).