From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 524D12BAF for ; Sun, 2 Jul 2017 22:15:53 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Jul 2017 13:15:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,299,1496127600"; d="scan'208";a="121995983" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga006.fm.intel.com with ESMTP; 02 Jul 2017 13:15:50 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.26]) by IRSMSX102.ger.corp.intel.com ([169.254.2.211]) with mapi id 14.03.0319.002; Sun, 2 Jul 2017 21:15:50 +0100 From: "Mcnamara, John" To: "De Lara Guarch, Pablo" , "Doherty, Declan" , "zbigniew.bodek@caviumnetworks.com" , "jerin.jacob@caviumnetworks.com" , "akhil.goyal@nxp.com" , "hemant.agrawal@nxp.com" , "Trahe, Fiona" , "Griffin, John" , "Jain, Deepak K" CC: "dev@dpdk.org" , "De Lara Guarch, Pablo" , "Mrozowicz, SlawomirX" Thread-Topic: [dpdk-dev] [PATCH v2 11/11] doc: add new crypto session information Thread-Index: AQHS8gcCQ2Nx6FiT5U6Jey/p1mHDGqJA+fdQ Date: Sun, 2 Jul 2017 20:15:48 +0000 Message-ID: References: <20170526184538.27292-1-michalx.k.jastrzebski@intel.com> <20170630170933.56631-1-pablo.de.lara.guarch@intel.com> <20170630170933.56631-12-pablo.de.lara.guarch@intel.com> In-Reply-To: <20170630170933.56631-12-pablo.de.lara.guarch@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmE3YmZmZGUtMWI3Ni00ZTU4LWI4MDYtNDBlOWQ3NjgyMTAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IitpSVhTYnlFcFE0QnZoK1JSdWFwMXp4ZTNDVG9GaW1MT1wvSTVraGdDOTRjPSJ9 dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 11/11] doc: add new crypto session information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Jul 2017 20:15:53 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, June 30, 2017 6:10 PM > To: Doherty, Declan ; > zbigniew.bodek@caviumnetworks.com; jerin.jacob@caviumnetworks.com; > akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Trahe, Fiona > ; Griffin, John ; Jain, > Deepak K > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > Mrozowicz, SlawomirX > Subject: [dpdk-dev] [PATCH v2 11/11] doc: add new crypto session > information >=20 > Modified cryptodev library section in Programmer's Guide, with the recent > changes in the rypto sessions. s/rypto/crypto/ >=20 > Signed-off-by: Slawomir Mrozowicz > Signed-off-by: Pablo de Lara > ... > +The Crypto device framework provides APIs to allocate and initizalize > +sessions for crypto devices, where sessions are mempool objects. > +It is the application responsability to create and manage the session > mempools. s/application/application's/ s/responsability/responsibility/ > +This approach allows for different scenarios such as having a single > +session mempool for all crypto devices (where the the mempool object s/the the/the/ > +size is big enough to hold the private session of any crypto device), > +as well as having multiple session mempools of different sizes for bette= r > memory usage. > + > +An application could use ``rte_cryptodev_get_private_session_size()`` > +to get the private session size of given crypto device. This function s/could/can/ is probably better. s/given/a given/ > +would allow an application to calculate the max device session size of > +all crypto devices to create a single session mempool. > +If instead an application creates multiple session mempools, the Crypto > +device framework also provides > +``rte_cryptodev_get_header_session_size`` to get the size of an > uninitialized session. > + > +Once the session mempools have been created, > +``rte_cryptodev_sym_session_create()`` > +is used to allocate an uninitialized session from the given mempool. > +The session then must be initialized ``rte_cryptodev_sym_session_init()`= ` > +for each of the crypto devices to be used with. A symmetric transform Probably better as:=20 The session then must be initialized using ``rte_cryptodev_sym_session_= init()`` for each of the required crypto devices. A symmetric transform > +chain is used to specify the operation and its parameters. See the > +section below for details on transforms. > + > +Unused session should be free using ``rte_cryptodev_sym_session_free`` > +which returns them to their mempool. s/free/freed/ Apart from these small changes which could be made inline: Acked-by: John McNamara