From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4B9302C8 for ; Thu, 6 Jul 2017 10:29:04 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jul 2017 01:29:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,316,1496127600"; d="scan'208";a="282792762" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga004.fm.intel.com with ESMTP; 06 Jul 2017 01:29:02 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.26]) by IRSMSX103.ger.corp.intel.com ([169.254.3.9]) with mapi id 14.03.0319.002; Thu, 6 Jul 2017 09:29:01 +0100 From: "Mcnamara, John" To: Tom Barbette , "dev@dpdk.org" CC: Thomas Monjalon Thread-Topic: [PATCH v2] ethernet api: Document rte_eth_vmdq_rx_conf Thread-Index: AQHS9ZdZ0GJscckmwUKO8F90anoc5aJGd3wg Date: Thu, 6 Jul 2017 08:29:01 +0000 Message-ID: References: <20170705135944.20655-1-tom.barbette@ulg.ac.be> In-Reply-To: <20170705135944.20655-1-tom.barbette@ulg.ac.be> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGFmYTBmYzYtYjNhOC00MGUxLTk1OWQtYTRmMTNkM2ZjYmM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjZSUVwvR0MyY3ZEUUV3SXExZjI4M1ltd3ZhMSsxVUswTWU5N1wvczFhU20xOD0ifQ== dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] ethernet api: Document rte_eth_vmdq_rx_conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2017 08:29:04 -0000 > -----Original Message----- > From: Tom Barbette [mailto:tom.barbette@ulg.ac.be] > Sent: Wednesday, July 5, 2017 3:00 PM > To: dev@dpdk.org > Cc: Thomas Monjalon ; Mcnamara, John > ; Tom Barbette > Subject: [PATCH v2] ethernet api: Document rte_eth_vmdq_rx_conf >=20 > From documentation it is very unclear how VMDq configuration can be > tweaked, and online search offer very poor results. >=20 > This patch will ultimately spawn an online documentation page for the > rte_eth_vmdq_rx_conf struct which will eventually add a bit of > documentation about the rx_mode tag and how to allow e.g. VMDq pools to > receive packets without VLAN tags. >=20 > Signed-off-by: Tom Barbette Hi Tom, Thanks for that. One minor, non-blocking, thing for future reference. The subject line should be lowercase apart from acronyms. The maintainer should be able to make that change when then apply the patch. This is just for future reference. If there is any other missing documentation that you would care to add then please do. :-) Acked-by: John McNamara