From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id 8DC28998A
for <dev@dpdk.org>; Fri, 28 Jul 2017 14:07:29 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
28 Jul 2017 05:07:28 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,425,1496127600"; d="scan'208";a="1177321069"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
by fmsmga001.fm.intel.com with ESMTP; 28 Jul 2017 05:07:15 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.9]) by
IRSMSX104.ger.corp.intel.com ([169.254.5.26]) with mapi id 14.03.0319.002;
Fri, 28 Jul 2017 13:07:09 +0100
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>, "thomas@monjalon.net"
<thomas@monjalon.net>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v4 3/3] doc: update mlx guides
Thread-Index: AQHTBjElE/4quc9u4UmMfANmcgdN+KJpJOVg
Date: Fri, 28 Jul 2017 12:07:09 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE23ED526D8@IRSMSX103.ger.corp.intel.com>
References: <50a96ef776aa322a707a558e01b46920f273fa99.1501051600.git.shahafs@mellanox.com>
<3051d9dfa6df6e4951886ed743a6c7eba8f0e70e.1501088435.git.shahafs@mellanox.com>
In-Reply-To: <3051d9dfa6df6e4951886ed743a6c7eba8f0e70e.1501088435.git.shahafs@mellanox.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ctpclassification: CTP_IC
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjUxM2QzYmItYmFmYS00MmIxLTgzMjktNDA5YmUzNDBlZjM5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlJ2RWlPZWduZGVUUzlZUXpOSjJXUTFSeFViWnMrVUI0YmJzUDhOTkFRS3M9In0=
dlp-product: dlpe-windows
dlp-version: 10.0.102.7
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v4 3/3] doc: update mlx guides
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Jul 2017 12:07:30 -0000
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler
> Sent: Wednesday, July 26, 2017 6:03 PM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v4 3/3] doc: update mlx guides
>=20
> Update the guides with:
> * New supported features.
> * Supported OFED and FW versions.
> * Quick start guide.
> * Performance tunning guide.
>=20
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> +6. Restart the driver:
> +
> + .. code-block:: console
> +
> + /etc/init.d/openibd restart
> + or:
> +
> + .. code-block:: console
> +
> + service openibd restart
You are missing a blank line before the "or:" in the mlx4.rst and mlx5.rst =
files
which causes the following RST warnings:
$ make doc-guides-html
doc/guides/nics/mlx4.rst:341:=20
WARNING: Explicit markup ends without a blank line; unexpected unindent=
.
doc/guides/nics/mlx5.rst:416:=20
WARNING: Explicit markup ends without a blank line; unexpected unindent=
.
> +6. Verify IO non-posted prefetch is disabled by default. This can be
> checked
> + via the BIOS configuration. Please contact you server provider for
> more
> + information about the settings.
> +
> +.. hint::
> +
> + On some machines, depends on the machine integrator, it is
Nice. I wasn't aware of the "hint" directive. Although "note::" is quite
similar.
John