From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>,
"Griffin, John" <john.griffin@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: announce API change in crypto driver allocation
Date: Thu, 3 Aug 2017 10:39:36 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23ED5925D@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20170803010236.17503-1-pablo.de.lara.guarch@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Thursday, August 3, 2017 2:03 AM
> To: thomas@monjalon.net; jerin.jacob@caviumnetworks.com;
> akhil.goyal@nxp.com; hemant.agrawal@nxp.com; Trahe, Fiona
> <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> Griffin, John <john.griffin@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH] doc: announce API change in crypto driver
> allocation
>
> rte_cryptodev_allocate_driver() function gets one parameter (rte_driver),
> as the cryptodev_driver structure is allocated inside the function with
> rte_malloc.
>
> This function is called from a constructor function, when crypto PMDs are
> registered.
> If malloc fails, there is no way to recover from it, so it is better to
> allocate this structure statically, in each PMD.
>
> Therefore, it is required to add an extra parameter in this function, to
> also get a pointer to this structure.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: John McNamara <john.mcnamara@intel.com>
next prev parent reply other threads:[~2017-08-03 10:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-03 1:02 Pablo de Lara
2017-08-03 10:39 ` Mcnamara, John [this message]
2017-08-03 10:43 ` Akhil Goyal
2017-08-08 10:21 ` Thomas Monjalon
2017-08-03 14:14 ` Jain, Deepak K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23ED5925D@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=john.griffin@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).