From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 38CF63257 for ; Thu, 3 Aug 2017 12:55:47 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP; 03 Aug 2017 03:55:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,315,1498546800"; d="scan'208";a="135585450" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga006.fm.intel.com with ESMTP; 03 Aug 2017 03:55:46 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.9]) by IRSMSX102.ger.corp.intel.com ([169.254.2.211]) with mapi id 14.03.0319.002; Thu, 3 Aug 2017 11:55:45 +0100 From: "Mcnamara, John" To: "Van Haaren, Harry" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "Van Haaren, Harry" Thread-Topic: [dpdk-dev] [PATCH] doc: add author on cc to git fixline alias Thread-Index: AQHS+xRTOM+put7igkKb2ajfObhD9qJyl9rw Date: Thu, 3 Aug 2017 10:55:44 +0000 Message-ID: References: <1499866732-17085-1-git-send-email-harry.van.haaren@intel.com> In-Reply-To: <1499866732-17085-1-git-send-email-harry.van.haaren@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDcwZjdkMzUtY2RkZS00MTQ4LTg3MTktMzFhMTczOTZjZjdkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik52czFMNk4zaFhjdklWa3FyaTRQQ0FHMXV3WmlaMDVDQzN1OXZmTkxMWVk9In0= dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: add author on cc to git fixline alias X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 10:55:48 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren > Sent: Wednesday, July 12, 2017 2:39 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Van Haaren, Harry > Subject: [dpdk-dev] [PATCH] doc: add author on cc to git fixline alias >=20 > With this commit, the correct method to use git fixline to indicate a fix > of a previous commit has changed. The new rules require the author of the > original code that is being fixed to be on CC. >=20 > The logic behind this improvement is that if there is a genuine bug, one > of the ideal people to review is the author of the original code being > fixed. Adding them on Cc makes them aware of the patch, avoiding it from > being passed by accidentally while reading the mailing-list. >=20 > Given that the original author (now on Cc:) might not actually review, > there is no value in keeping the Cc: in git commit history. If the > original author performs a review, their Reviewed-by: or Acked-by: is > stored in git history (same as now). >=20 > Signed-off-by: Harry van Haaren Acked-by: John McNamara