From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Hu, Jiayu" <jiayu.hu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2] doc: add prog_guide for the GRO library
Date: Fri, 4 Aug 2017 09:11:18 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23ED5A5B5@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1501834844-25765-1-git-send-email-jiayu.hu@intel.com>
> -----Original Message-----
> From: Hu, Jiayu
> Sent: Friday, August 4, 2017 9:21 AM
> To: dev@dpdk.org
> Cc: thomas@monjalon.net; Mcnamara, John <john.mcnamara@intel.com>; Hu,
> Jiayu <jiayu.hu@intel.com>
> Subject: [PATCH v2] doc: add prog_guide for the GRO library
>
> Add prog_guide doc to explain the design of the GRO library.
> ...
> +Generic Receive Offload Library
> +===============================
> +
> ...
> +
> +The GRO library assumes all inputted packets are with correct checksums.
> +In addition, the GRO library doesn't re-calculate checksums for merged
> +packets. If inputted packets are IP fragmented, the GRO library assumes
> +they are complete packets (i.e. with L4 headers).
It is more correct/common to use input instead of inputted. You should
make this change throughout the doc.
Also this bout be better as:
The GRO library assumes all input packets have correct checksums. In addition, the GRO library doesn't re-calculate checksums for merged packets.
Apart from that:
Acked-by: John McNamara <john.mcnamara@intel.com>
next prev parent reply other threads:[~2017-08-04 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 3:27 [dpdk-dev] [PATCH] doc: update programmer's guide " Jiayu Hu
2017-07-21 15:09 ` Thomas Monjalon
2017-08-03 14:41 ` Mcnamara, John
2017-08-04 0:50 ` Hu, Jiayu
2017-08-04 8:20 ` [dpdk-dev] [PATCH v2] doc: add prog_guide " Jiayu Hu
2017-08-04 9:11 ` Mcnamara, John [this message]
2017-08-04 9:37 ` Jiayu Hu
2017-08-04 9:59 ` [dpdk-dev] [PATCH v3] " Jiayu Hu
2017-08-06 12:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23ED5A5B5@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).