From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id D30BB2C18 for ; Fri, 4 Aug 2017 11:11:21 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Aug 2017 02:11:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,320,1498546800"; d="scan'208";a="119671057" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga002.jf.intel.com with ESMTP; 04 Aug 2017 02:11:19 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.9]) by IRSMSX107.ger.corp.intel.com ([169.254.10.129]) with mapi id 14.03.0319.002; Fri, 4 Aug 2017 10:11:19 +0100 From: "Mcnamara, John" To: "Hu, Jiayu" , "dev@dpdk.org" CC: "thomas@monjalon.net" Thread-Topic: [PATCH v2] doc: add prog_guide for the GRO library Thread-Index: AQHTDPpZ4jgLGKjeR0q4EQZLxqqCFKJz58Yg Date: Fri, 4 Aug 2017 09:11:18 +0000 Message-ID: References: <1499743655-86736-1-git-send-email-jiayu.hu@intel.com> <1501834844-25765-1-git-send-email-jiayu.hu@intel.com> In-Reply-To: <1501834844-25765-1-git-send-email-jiayu.hu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODMzMjBkNWEtYThhMi00NDgxLWFmMGQtYzdlMTJiNGY4N2U4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik1QZTJJRmt4b0VCYWRORkZud1VaOU9FOFpsNUJPcGpvZnBkbmtHbnZocjQ9In0= dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] doc: add prog_guide for the GRO library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Aug 2017 09:11:22 -0000 > -----Original Message----- > From: Hu, Jiayu > Sent: Friday, August 4, 2017 9:21 AM > To: dev@dpdk.org > Cc: thomas@monjalon.net; Mcnamara, John ; Hu, > Jiayu > Subject: [PATCH v2] doc: add prog_guide for the GRO library >=20 > Add prog_guide doc to explain the design of the GRO library. > ... > +Generic Receive Offload Library > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > + > ... > + > +The GRO library assumes all inputted packets are with correct checksums. > +In addition, the GRO library doesn't re-calculate checksums for merged > +packets. If inputted packets are IP fragmented, the GRO library assumes > +they are complete packets (i.e. with L4 headers). It is more correct/common to use input instead of inputted. You should make this change throughout the doc. Also this bout be better as: The GRO library assumes all input packets have correct checksums. In additi= on, the GRO library doesn't re-calculate checksums for merged packets. Apart from that: Acked-by: John McNamara