From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 719EF1B5EC for ; Mon, 23 Oct 2017 14:26:35 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2017 05:26:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,422,1503385200"; d="scan'208";a="165904763" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga005.fm.intel.com with ESMTP; 23 Oct 2017 05:26:33 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by IRSMSX102.ger.corp.intel.com ([169.254.2.180]) with mapi id 14.03.0319.002; Mon, 23 Oct 2017 13:26:33 +0100 From: "Mcnamara, John" To: "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH] doc: how to set VF MAC address on ixgbe Thread-Index: AQHTS8D6GtJI0GcgHEaZWy8uzzxuw6LxXJoQ Date: Mon, 23 Oct 2017 12:26:32 +0000 Message-ID: References: <1508737092-37275-1-git-send-email-wenzhuo.lu@intel.com> In-Reply-To: <1508737092-37275-1-git-send-email-wenzhuo.lu@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTEzM2M2ZDQtZmM3YS00NDlmLTk1NmUtZGYyNzBhNGI3MWI0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlphMzFFTnJncGR1WnBLSjJ5OW9ydWdVcTNjZlZORExvWHVqM0JJV2psZEE9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: how to set VF MAC address on ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 12:26:35 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Monday, October 23, 2017 6:38 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] doc: how to set VF MAC address on ixgbe >=20 > Add the description of how to add a MAC address for a VF from PF on ixgbe= . >=20 > Signed-off-by: Wenzhuo Lu > --- > doc/guides/nics/ixgbe.rst | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst index > 696ff69..bd0dc68 100644 > --- a/doc/guides/nics/ixgbe.rst > +++ b/doc/guides/nics/ixgbe.rst > @@ -227,6 +227,17 @@ So when the user sets different MTUs on PF and VF > ports in one physical port, the real MTU for all these PF and VF ports i= s > the largest value set. > This behavior is based on the kernel driver behavior. >=20 > +VF MAC address setting > +~~~~~~~~~~~~~~~~~~~~~~ > + > +On ixgbe, the concept pool can be used for different things. It depends > +on the mode. In VMDq mode, the pool means a VMDq pool. In IOV mode, the > +pool means a VF. > +When setting the parameters of a pool, in VMDq mode, it's for a VMDq > +pool, in IOV mode, it's for a VF. > +There's no RTE API to add a VF's MAC address from PF. On ixgbe, there's > +a workaround to do it. "rte_eth_dev_mac_addr_add" also can be used to > +add a VF's MAC address. I'd suggest something like the following may be a bit clearer: VF MAC address setting ~~~~~~~~~~~~~~~~~~~~~~ On ixgbe, the concept of "pool" can be used for different things depending = on the mode. In VMDq mode, "pool" means a VMDq pool. In IOV mode, "pool" means= a VF. There is no RTE API to add a VF's MAC address from the PF. On ixgbe, the ``rte_eth_dev_mac_addr_add()`` function can be can be used to add a VF's MA= C address, as a workaround.