From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 581A17CBA; Mon, 11 Dec 2017 15:26:38 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2017 06:26:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,391,1508828400"; d="scan'208";a="185664911" Received: from irsmsx108.ger.corp.intel.com ([163.33.3.3]) by fmsmga005.fm.intel.com with ESMTP; 11 Dec 2017 06:26:35 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.49]) by IRSMSX108.ger.corp.intel.com ([169.254.11.167]) with mapi id 14.03.0319.002; Mon, 11 Dec 2017 14:26:34 +0000 From: "Mcnamara, John" To: "Yigit, Ferruh" , Thomas Monjalon CC: "dev@dpdk.org" , "techboard@dpdk.org" Thread-Topic: [PATCH] doc: update contribution guideline for dependent work Thread-Index: AQHTYwM60OdWh6d+A068OVOE0Wk6cqM+Uabw Date: Mon, 11 Dec 2017 14:26:34 +0000 Message-ID: References: <20171121195905.66410-1-ferruh.yigit@intel.com> In-Reply-To: <20171121195905.66410-1-ferruh.yigit@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjVjZjRkYmYtNDViMS00NmZiLTk4ZDQtYzAzZjNjNTNkM2E4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IjB1XC9UTk51NVY5aFhHYzc1VVpyOFwvVERlV1JxYkowemVsc0xRYTlcL2t2ZnM9In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: update contribution guideline for dependent work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Dec 2017 14:26:38 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, November 21, 2017 7:59 PM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org; Yigit, Ferruh ; > techboard@dpdk.org > Subject: [PATCH] doc: update contribution guideline for dependent work >=20 > Changing some part of the libraries but not updating all dependent code > cause maintenance problems. >=20 > ... >=20 > Signed-off-by: Ferruh Yigit >=20 integration testing. >=20 > +* If changes effect other parts of the project, update all those parts a= s > well unless updating requires special knowledge. > + For the cases not all effected code updated, ensure that changes don't > break existing code. > + > * Add tests to the the ``app/test`` unit test framework where possible. >=20 > * Add documentation, if relevant, in the form of Doxygen comments or a > User Guide in RST format. Second line would be better as: For the cases where not all the effected code is updated, the submitter sho= uld ensure that changes don't break existing code. Acked-by: John McNamara