From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for igb
Date: Thu, 8 Feb 2018 12:27:23 +0000 [thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23EEAB97E@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <e1bad2ff-8849-aabf-3bf7-8dc648f7469a@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, February 8, 2018 11:39 AM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v3] doc: add a user guidance document for
> igb
>
> On 2/2/2018 3:29 AM, Wei Zhao wrote:
> > This patch add a user guidance document specific for igb nic.
> > By now, a doc like ixgbe.rst is also needed by igb nic. So this patch
> > add igb.rst to record important information about igb, like feature
> > supported and known issues.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> >
> > ---
> >
> > v2:
> > -change code indentation style.
> >
> > v3:
> > -add more details for igb feature.
> > ---
> > doc/guides/nics/igb.rst | 38 ++++++++++++++++++++++++++++++++++++++
>
> This file is not in the index, so you won't able select file from side bar
> and will be very hard to access this document unless you know the url,
> also producing a warning for same thing:
>
> .../doc/guides/nics/igb.rst: WARNING: document isn't included in any
> toctree
I missed that in the review. Can you fix that in the merge?
John
next prev parent reply other threads:[~2018-02-08 12:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 8:40 [dpdk-dev] [PATCH] " Wei Zhao
2018-01-31 8:47 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-02-01 9:13 ` Mcnamara, John
2018-02-02 3:38 ` Zhao1, Wei
2018-02-02 3:29 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2018-02-05 9:34 ` Mcnamara, John
2018-02-07 7:12 ` Zhang, Helin
2018-02-08 13:49 ` Ferruh Yigit
2018-02-08 11:38 ` Ferruh Yigit
2018-02-08 12:27 ` Mcnamara, John [this message]
2018-02-08 12:30 ` Ferruh Yigit
2018-02-13 3:30 ` Zhao1, Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B27915DBBA3421428155699D51E4CFE23EEAB97E@IRSMSX103.ger.corp.intel.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).