From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1F7812C5 for ; Tue, 31 Jul 2018 18:01:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2018 09:01:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,427,1526367600"; d="scan'208";a="77535765" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 31 Jul 2018 09:01:20 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.208]) by IRSMSX102.ger.corp.intel.com ([169.254.2.110]) with mapi id 14.03.0319.002; Tue, 31 Jul 2018 17:01:20 +0100 From: "Mcnamara, John" To: Stephen Hemminger , "nhorman@tuxdriver.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] devtools: check_symbol_change requires bash Thread-Index: AQHUKOFICKpSbc+NW02S/jyNVRNrjaSpfLYA Date: Tue, 31 Jul 2018 16:01:19 +0000 Message-ID: References: <20180731151416.4868-1-stephen@networkplumber.org> In-Reply-To: <20180731151416.4868-1-stephen@networkplumber.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2ZjMTA4MDYtNGNiOS00ODZhLTgyY2QtMjYwMzk2ZGFhMTMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSENnRVU0VkpzTlNCZG9laVwvT1hGREttQ1NJN0RFbUJzdk1KM0dHOEpjbUs5OHJwczY1YjBwYWtDZFY0TlhUUkoifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] devtools: check_symbol_change requires bash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2018 16:01:25 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, July 31, 2018 4:14 PM > To: nhorman@tuxdriver.com > Cc: dev@dpdk.org; Stephen Hemminger > Subject: [dpdk-dev] [PATCH] devtools: check_symbol_change requires bash >=20 > The syntax of check_symbol_change uses some bash syntax. > It does not run correctly on Debian where /bin/sh is not the same as > /bin/bash. I think this fix may be required for devtools/checkpatches.sh as well since it seems to use bash specific call to trap(). I saw this in an internal bug report but didn't have a system to check the fix on. Could you do a quick check. John --=20