From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by dpdk.org (Postfix) with ESMTP id BB11F4F91;
Wed, 1 Aug 2018 12:40:12 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
01 Aug 2018 03:40:10 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,431,1526367600"; d="scan'208";a="72373286"
Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23])
by fmsmga002.fm.intel.com with ESMTP; 01 Aug 2018 03:40:09 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.208]) by
IRSMSX109.ger.corp.intel.com ([169.254.13.124]) with mapi id 14.03.0319.002;
Wed, 1 Aug 2018 11:40:08 +0100
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Gavin Hu <gavin.hu@arm.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-stable] [PATCH] devtools: trap SIGINT is not
recognizable to dash
Thread-Index: AQHUKVfPYocUUO30aEG/PM69hcqDraSqtUIg
Date: Wed, 1 Aug 2018 10:40:08 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE23F3C5DAD@IRSMSX103.ger.corp.intel.com>
References: <20180801052257.14869-1-gavin.hu@arm.com>
In-Reply-To: <20180801052257.14869-1-gavin.hu@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-ctpclassification: CTP_NT
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmIwMzUwYjgtZDIxMi00YjBlLWEyYmQtYzI5NGI0NWZiYjhkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQlI1U2xVc3dTdkVhQlwvZ3lwREtkSEp6VVRmbGVIQTBoMlFqK2JESzl5bFwvWG5NSnZhejMrUENlYzVQWWpMVWhDIn0=
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] devtools: trap SIGINT is not
recognizable to dash
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Aug 2018 10:40:13 -0000
> -----Original Message-----
> From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Gavin Hu
> Sent: Wednesday, August 1, 2018 6:23 AM
> To: dev@dpdk.org
> Cc: honnappa.nagarahalli@arm.com; gavin.hu@arm.com; stable@dpdk.org
> Subject: [dpdk-stable] [PATCH] devtools: trap SIGINT is not recognizable =
to
> dash
>=20
> When running checkpatch.sh, it generates the following error on some linu=
x
> distributions(like Debian) with Dash as the default shell interpreter.
> trap: SIGINT: bad trap
>=20
> The fix is to replace SIGINT with INT signal, it works for both bash and
> dash.
>=20
> Fixes: 4bec48184e ("devtools: add checks for ABI symbol addition")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@amr.com>
Acked-by: John McNamara <john.mcnamara@intel.com>