From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 6104858F6 for ; Wed, 14 Nov 2018 16:04:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2018 07:04:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,232,1539673200"; d="scan'208";a="89246148" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga007.jf.intel.com with ESMTP; 14 Nov 2018 07:04:34 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.253]) by IRSMSX109.ger.corp.intel.com ([169.254.13.38]) with mapi id 14.03.0415.000; Wed, 14 Nov 2018 15:04:33 +0000 From: "Mcnamara, John" To: Sunila Sahu CC: "dev@dpdk.org" , "pathreya@caviumnetworks.com" , "nmurthy@caviumnetworks.com" , Ashish Gupta , "De Lara Guarch, Pablo" , Shally Verma Thread-Topic: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op Thread-Index: AQHUIpQUrDEPw5B7QUKsadvlI6kVjKVQEAKQ Date: Wed, 14 Nov 2018 15:04:32 +0000 Message-ID: References: <1532357165-8575-1-git-send-email-shally.verma@caviumnetworks.com> <1532357165-8575-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: <1532357165-8575-2-git-send-email-shally.verma@caviumnetworks.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjJlNTg4OGUtNjNhNS00MDI1LWJiN2MtMjhhNTU0MThlYjNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiS1ZxVUxSdG82V3VqN2FaZjM2YzljbGc4VGZKYmtcL3pMZ3Z1QkttSzA4RUxjVUFCaFBmVTFTa2tRMDB5bG5ZbUQifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2018 15:04:48 -0000 > +err_rsa: > + if (n) > + BN_free(n); > + if (e) > + BN_free(e); > + if (d) > + BN_free(d); > + if (p) > + BN_free(p); > + if (q) > + BN_free(q); > + if (dmp1) > + BN_free(dmp1); > + if (dmq1) > + BN_free(dmq1); > + if (iqmp) > + BN_free(iqmp); > + Hi, I don't think the if() test is required prior to calling BN_free(). The docs say: "If a is NULL, nothing is done.": https://www.openssl.org/docs/manmaster/man3/BN_free.html I mention this because the code above is also in Coverity defect 305854. Could you look at that and provide a fix. Thanks. John