From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 22A671B61B; Thu, 18 Apr 2019 11:21:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2019 02:21:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,365,1549958400"; d="scan'208";a="338604015" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga006.fm.intel.com with ESMTP; 18 Apr 2019 02:21:21 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.30]) by IRSMSX151.ger.corp.intel.com ([169.254.4.174]) with mapi id 14.03.0415.000; Thu, 18 Apr 2019 10:21:20 +0100 From: "Mcnamara, John" To: "Sirvys, Andrius" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Sirvys, Andrius" , "remy.horton@intel.com" Thread-Topic: [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return value Thread-Index: AQHU9cQpohNgPd3ZEk2mVu5bVYYynKZBpI5g Date: Thu, 18 Apr 2019 09:21:20 +0000 Message-ID: References: <20190418085206.86048-1-andrius.sirvys@intel.com> In-Reply-To: <20190418085206.86048-1-andrius.sirvys@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGQ0NjA1ZDQtOGQzMS00OWJkLWE5MzgtNTBmMDIxN2NmMjIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZVlqMkI5ZTJ2WEtTcXpnMVo4UjJsQ2hvZ3pVSFkwUEE1RmMwcU1BdUoyUmFRYTBHY2JoZG1Dd2Qwd2psaURlOSJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Apr 2019 09:21:25 -0000 > -----Original Message----- > From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Andrius Sirvys > Sent: Thursday, April 18, 2019 9:52 AM > To: dev@dpdk.org > Cc: stable@dpdk.org; Sirvys, Andrius ; > remy.horton@intel.com > Subject: [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return > value >=20 > Checking the return value of rte_metrics_update_values, if failed > returning that value. > Coverity had picked up that that the return value wasn't being checked. >=20 > Coverity issue: 336863 > Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") > Cc: remy.horton@intel.com >=20 > Signed-off-by: Andrius Sirvys > Acked-by: Rami Rosen Acked-by: John McNamara From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 13348A00E6 for ; Thu, 18 Apr 2019 11:21:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 950B21B8CB; Thu, 18 Apr 2019 11:21:26 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 22A671B61B; Thu, 18 Apr 2019 11:21:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2019 02:21:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,365,1549958400"; d="scan'208";a="338604015" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga006.fm.intel.com with ESMTP; 18 Apr 2019 02:21:21 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.30]) by IRSMSX151.ger.corp.intel.com ([169.254.4.174]) with mapi id 14.03.0415.000; Thu, 18 Apr 2019 10:21:20 +0100 From: "Mcnamara, John" To: "Sirvys, Andrius" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Sirvys, Andrius" , "remy.horton@intel.com" Thread-Topic: [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return value Thread-Index: AQHU9cQpohNgPd3ZEk2mVu5bVYYynKZBpI5g Date: Thu, 18 Apr 2019 09:21:20 +0000 Message-ID: References: <20190418085206.86048-1-andrius.sirvys@intel.com> In-Reply-To: <20190418085206.86048-1-andrius.sirvys@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGQ0NjA1ZDQtOGQzMS00OWJkLWE5MzgtNTBmMDIxN2NmMjIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZVlqMkI5ZTJ2WEtTcXpnMVo4UjJsQ2hvZ3pVSFkwUEE1RmMwcU1BdUoyUmFRYTBHY2JoZG1Dd2Qwd2psaURlOSJ9 dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190418092120.CI5cLsze8Pvh-bVCT7AXxF4KztRzt6v_rcx32N1Ehe4@z> > -----Original Message----- > From: stable [mailto:stable-bounces@dpdk.org] On Behalf Of Andrius Sirvys > Sent: Thursday, April 18, 2019 9:52 AM > To: dev@dpdk.org > Cc: stable@dpdk.org; Sirvys, Andrius ; > remy.horton@intel.com > Subject: [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return > value >=20 > Checking the return value of rte_metrics_update_values, if failed > returning that value. > Coverity had picked up that that the return value wasn't being checked. >=20 > Coverity issue: 336863 > Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") > Cc: remy.horton@intel.com >=20 > Signed-off-by: Andrius Sirvys > Acked-by: Rami Rosen Acked-by: John McNamara