* [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity
@ 2019-04-29 9:40 Yipeng Wang
2019-04-29 9:40 ` Yipeng Wang
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Yipeng Wang @ 2019-04-29 9:40 UTC (permalink / raw)
To: yipeng1.wang, pablo.de.lara.guarch, gentoorion, anatoly.burakov; +Cc: dev
rte_hash_hash is multi-thread safe but not multi-process safe
because of the use of function pointers. Previous document
and comment says the other way around. This commit fixes
the issue.
Fixes: fc1f2750a3ec ("doc: programmers guide")
Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
Cc: stable@dpdk.org
Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>
Suggested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Reported-by: Andrey Nikolaev <gentoorion@gmail.com>
---
doc/guides/prog_guide/multi_proc_support.rst | 2 +-
lib/librte_hash/rte_hash.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst
index 1384fe3..761fca9 100644
--- a/doc/guides/prog_guide/multi_proc_support.rst
+++ b/doc/guides/prog_guide/multi_proc_support.rst
@@ -176,7 +176,7 @@ Some of these are documented below:
* The use of function pointers between multiple processes running based of different compiled binaries is not supported,
since the location of a given function in one process may be different to its location in a second.
- This prevents the librte_hash library from behaving properly as in a multi-threaded instance,
+ This prevents the librte_hash library from behaving properly as in a multi-process instance,
since it uses a pointer to the hash function internally.
To work around this issue, it is recommended that multi-process applications perform the hash calculations by directly calling
diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
index c93d1a1..abba8d7 100644
--- a/lib/librte_hash/rte_hash.h
+++ b/lib/librte_hash/rte_hash.h
@@ -463,7 +463,7 @@ rte_hash_lookup_with_hash(const struct rte_hash *h,
/**
* Calc a hash value by key.
- * This operation is not multi-thread safe.
+ * This operation is not multi-process safe.
*
* @param h
* Hash table to look in.
--
2.7.4
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity
2019-04-29 9:40 [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity Yipeng Wang
@ 2019-04-29 9:40 ` Yipeng Wang
2019-04-29 20:05 ` Dharmik Thakkar
2019-04-30 11:20 ` Mcnamara, John
2 siblings, 0 replies; 8+ messages in thread
From: Yipeng Wang @ 2019-04-29 9:40 UTC (permalink / raw)
To: yipeng1.wang, pablo.de.lara.guarch, gentoorion, anatoly.burakov; +Cc: dev
rte_hash_hash is multi-thread safe but not multi-process safe
because of the use of function pointers. Previous document
and comment says the other way around. This commit fixes
the issue.
Fixes: fc1f2750a3ec ("doc: programmers guide")
Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
Cc: stable@dpdk.org
Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>
Suggested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Reported-by: Andrey Nikolaev <gentoorion@gmail.com>
---
doc/guides/prog_guide/multi_proc_support.rst | 2 +-
lib/librte_hash/rte_hash.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst
index 1384fe3..761fca9 100644
--- a/doc/guides/prog_guide/multi_proc_support.rst
+++ b/doc/guides/prog_guide/multi_proc_support.rst
@@ -176,7 +176,7 @@ Some of these are documented below:
* The use of function pointers between multiple processes running based of different compiled binaries is not supported,
since the location of a given function in one process may be different to its location in a second.
- This prevents the librte_hash library from behaving properly as in a multi-threaded instance,
+ This prevents the librte_hash library from behaving properly as in a multi-process instance,
since it uses a pointer to the hash function internally.
To work around this issue, it is recommended that multi-process applications perform the hash calculations by directly calling
diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
index c93d1a1..abba8d7 100644
--- a/lib/librte_hash/rte_hash.h
+++ b/lib/librte_hash/rte_hash.h
@@ -463,7 +463,7 @@ rte_hash_lookup_with_hash(const struct rte_hash *h,
/**
* Calc a hash value by key.
- * This operation is not multi-thread safe.
+ * This operation is not multi-process safe.
*
* @param h
* Hash table to look in.
--
2.7.4
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity
2019-04-29 9:40 [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity Yipeng Wang
2019-04-29 9:40 ` Yipeng Wang
@ 2019-04-29 20:05 ` Dharmik Thakkar
2019-04-29 20:05 ` Dharmik Thakkar
2019-04-30 11:20 ` Mcnamara, John
2 siblings, 1 reply; 8+ messages in thread
From: Dharmik Thakkar @ 2019-04-29 20:05 UTC (permalink / raw)
To: Yipeng Wang; +Cc: Pablo de Lara, gentoorion, anatoly.burakov, dev, nd
> On Apr 29, 2019, at 4:40 AM, Yipeng Wang <yipeng1.wang@intel.com> wrote:
>
> rte_hash_hash is multi-thread safe but not multi-process safe
> because of the use of function pointers. Previous document
> and comment says the other way around. This commit fixes
> the issue.
>
> Fixes: fc1f2750a3ec ("doc: programmers guide")
> Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>
> Suggested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Reported-by: Andrey Nikolaev <gentoorion@gmail.com>
> ---
> doc/guides/prog_guide/multi_proc_support.rst | 2 +-
> lib/librte_hash/rte_hash.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst
> index 1384fe3..761fca9 100644
> --- a/doc/guides/prog_guide/multi_proc_support.rst
> +++ b/doc/guides/prog_guide/multi_proc_support.rst
> @@ -176,7 +176,7 @@ Some of these are documented below:
>
> * The use of function pointers between multiple processes running based of different compiled binaries is not supported,
> since the location of a given function in one process may be different to its location in a second.
> - This prevents the librte_hash library from behaving properly as in a multi-threaded instance,
> + This prevents the librte_hash library from behaving properly as in a multi-process instance,
> since it uses a pointer to the hash function internally.
>
> To work around this issue, it is recommended that multi-process applications perform the hash calculations by directly calling
> diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
> index c93d1a1..abba8d7 100644
> --- a/lib/librte_hash/rte_hash.h
> +++ b/lib/librte_hash/rte_hash.h
> @@ -463,7 +463,7 @@ rte_hash_lookup_with_hash(const struct rte_hash *h,
>
> /**
> * Calc a hash value by key.
> - * This operation is not multi-thread safe.
> + * This operation is not multi-process safe.
> *
> * @param h
> * Hash table to look in.
> --
> 2.7.4
>
Acked-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity
2019-04-29 20:05 ` Dharmik Thakkar
@ 2019-04-29 20:05 ` Dharmik Thakkar
0 siblings, 0 replies; 8+ messages in thread
From: Dharmik Thakkar @ 2019-04-29 20:05 UTC (permalink / raw)
To: Yipeng Wang; +Cc: Pablo de Lara, gentoorion, anatoly.burakov, dev, nd
> On Apr 29, 2019, at 4:40 AM, Yipeng Wang <yipeng1.wang@intel.com> wrote:
>
> rte_hash_hash is multi-thread safe but not multi-process safe
> because of the use of function pointers. Previous document
> and comment says the other way around. This commit fixes
> the issue.
>
> Fixes: fc1f2750a3ec ("doc: programmers guide")
> Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>
> Suggested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Reported-by: Andrey Nikolaev <gentoorion@gmail.com>
> ---
> doc/guides/prog_guide/multi_proc_support.rst | 2 +-
> lib/librte_hash/rte_hash.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/prog_guide/multi_proc_support.rst b/doc/guides/prog_guide/multi_proc_support.rst
> index 1384fe3..761fca9 100644
> --- a/doc/guides/prog_guide/multi_proc_support.rst
> +++ b/doc/guides/prog_guide/multi_proc_support.rst
> @@ -176,7 +176,7 @@ Some of these are documented below:
>
> * The use of function pointers between multiple processes running based of different compiled binaries is not supported,
> since the location of a given function in one process may be different to its location in a second.
> - This prevents the librte_hash library from behaving properly as in a multi-threaded instance,
> + This prevents the librte_hash library from behaving properly as in a multi-process instance,
> since it uses a pointer to the hash function internally.
>
> To work around this issue, it is recommended that multi-process applications perform the hash calculations by directly calling
> diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h
> index c93d1a1..abba8d7 100644
> --- a/lib/librte_hash/rte_hash.h
> +++ b/lib/librte_hash/rte_hash.h
> @@ -463,7 +463,7 @@ rte_hash_lookup_with_hash(const struct rte_hash *h,
>
> /**
> * Calc a hash value by key.
> - * This operation is not multi-thread safe.
> + * This operation is not multi-process safe.
> *
> * @param h
> * Hash table to look in.
> --
> 2.7.4
>
Acked-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity
2019-04-29 9:40 [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity Yipeng Wang
2019-04-29 9:40 ` Yipeng Wang
2019-04-29 20:05 ` Dharmik Thakkar
@ 2019-04-30 11:20 ` Mcnamara, John
2019-04-30 11:20 ` Mcnamara, John
2019-05-04 21:32 ` Thomas Monjalon
2 siblings, 2 replies; 8+ messages in thread
From: Mcnamara, John @ 2019-04-30 11:20 UTC (permalink / raw)
To: Wang, Yipeng1, Wang, Yipeng1, De Lara Guarch, Pablo, gentoorion,
Burakov, Anatoly
Cc: dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yipeng Wang
> Sent: Monday, April 29, 2019 10:40 AM
> To: Wang, Yipeng1 <yipeng1.wang@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; gentoorion@gmail.com; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity
>
> rte_hash_hash is multi-thread safe but not multi-process safe because of
> the use of function pointers. Previous document and comment says the other
> way around. This commit fixes the issue.
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity
2019-04-30 11:20 ` Mcnamara, John
@ 2019-04-30 11:20 ` Mcnamara, John
2019-05-04 21:32 ` Thomas Monjalon
1 sibling, 0 replies; 8+ messages in thread
From: Mcnamara, John @ 2019-04-30 11:20 UTC (permalink / raw)
To: Wang, Yipeng1, Wang, Yipeng1, De Lara Guarch, Pablo, gentoorion,
Burakov, Anatoly
Cc: dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yipeng Wang
> Sent: Monday, April 29, 2019 10:40 AM
> To: Wang, Yipeng1 <yipeng1.wang@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; gentoorion@gmail.com; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity
>
> rte_hash_hash is multi-thread safe but not multi-process safe because of
> the use of function pointers. Previous document and comment says the other
> way around. This commit fixes the issue.
Acked-by: John McNamara <john.mcnamara@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity
2019-04-30 11:20 ` Mcnamara, John
2019-04-30 11:20 ` Mcnamara, John
@ 2019-05-04 21:32 ` Thomas Monjalon
2019-05-04 21:32 ` Thomas Monjalon
1 sibling, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2019-05-04 21:32 UTC (permalink / raw)
To: Wang, Yipeng1
Cc: dev, Mcnamara, John, De Lara Guarch, Pablo, gentoorion, Burakov, Anatoly
> > rte_hash_hash is multi-thread safe but not multi-process safe because of
> > the use of function pointers. Previous document and comment says the other
> > way around. This commit fixes the issue.
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity
2019-05-04 21:32 ` Thomas Monjalon
@ 2019-05-04 21:32 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-05-04 21:32 UTC (permalink / raw)
To: Wang, Yipeng1
Cc: dev, Mcnamara, John, De Lara Guarch, Pablo, gentoorion, Burakov, Anatoly
> > rte_hash_hash is multi-thread safe but not multi-process safe because of
> > the use of function pointers. Previous document and comment says the other
> > way around. This commit fixes the issue.
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-05-04 21:32 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-29 9:40 [dpdk-dev] [PATCH] doc: fix rte_hash_hash comment for ambiguity Yipeng Wang
2019-04-29 9:40 ` Yipeng Wang
2019-04-29 20:05 ` Dharmik Thakkar
2019-04-29 20:05 ` Dharmik Thakkar
2019-04-30 11:20 ` Mcnamara, John
2019-04-30 11:20 ` Mcnamara, John
2019-05-04 21:32 ` Thomas Monjalon
2019-05-04 21:32 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).