From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id AC8F4902 for ; Wed, 27 May 2015 09:29:51 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 27 May 2015 00:29:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,503,1427785200"; d="scan'208";a="732307446" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga002.fm.intel.com with ESMTP; 27 May 2015 00:29:33 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.215]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0224.002; Wed, 27 May 2015 08:29:33 +0100 From: "Mcnamara, John" To: Simon Kagstrom , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] eal_common_options: Allow combining -m and --no-huge Thread-Index: AQHQkvgSFjFPEL0/SEqqHcZywPpe252Pdy5g Date: Wed, 27 May 2015 07:29:33 +0000 Message-ID: References: <20150520142427.4b977210@miho> In-Reply-To: <20150520142427.4b977210@miho> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] eal_common_options: Allow combining -m and --no-huge X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 May 2015 07:29:52 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Simon Kagstrom > Sent: Wednesday, May 20, 2015 1:24 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] eal_common_options: Allow combining -m and -- > no-huge >=20 > Needed to run as non-root but with higher memory allocations. >=20 > Signed-off-by: Simon Kagstrom > Signed-off-by: Johan Faltstrom > --- > lib/librte_eal/common/eal_common_options.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_eal/common/eal_common_options.c > b/lib/librte_eal/common/eal_common_options.c > index 8fcb1ab..89b867d 100644 > --- a/lib/librte_eal/common/eal_common_options.c > +++ b/lib/librte_eal/common/eal_common_options.c > @@ -851,8 +851,8 @@ eal_check_common_options(struct internal_config > *internal_cfg) > return -1; > } > if (internal_cfg->no_hugetlbfs && > - (mem_parsed || internal_cfg->force_sockets =3D=3D 1)) { > - RTE_LOG(ERR, EAL, "Options -m or --"OPT_SOCKET_MEM" cannot " > + (internal_cfg->force_sockets =3D=3D 1)) { > + RTE_LOG(ERR, EAL, "Option --"OPT_SOCKET_MEM" cannot " > "be specified together with --"OPT_NO_HUGE"\n"); > return -1; > } Hi, Minor comments. * Without mem_parsed the () aren't required and the conditional will fit on= one line. * The section prefix on the first/subject line should be "eal:" and the com= mit message/justification could be clearer. It would be worth doing a "git = log" on the file and following the previous conventions for commit message = on that component/file. John