From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 19D945A58 for ; Tue, 9 Jun 2015 14:15:20 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 09 Jun 2015 05:15:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,579,1427785200"; d="scan'208";a="584676121" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga003.jf.intel.com with ESMTP; 09 Jun 2015 05:15:20 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.215]) by IRSMSX152.ger.corp.intel.com ([169.254.6.148]) with mapi id 14.03.0224.002; Tue, 9 Jun 2015 13:15:18 +0100 From: "Mcnamara, John" To: Maxim Uvarov , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] support jumbo frames for pcap vdev Thread-Index: AQHQop1YUlgD5vZAZEO7s47s0mMwtp2kFdkg Date: Tue, 9 Jun 2015 12:15:17 +0000 Message-ID: References: <1433844923-29797-1-git-send-email-maxim.uvarov@linaro.org> In-Reply-To: <1433844923-29797-1-git-send-email-maxim.uvarov@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "tero.aho@coriant.com" Subject: Re: [dpdk-dev] [PATCH] support jumbo frames for pcap vdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2015 12:15:22 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Maxim Uvarov > Sent: Tuesday, June 9, 2015 11:15 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] support jumbo frames for pcap vdev >=20 > PCAP PMD vdev is used mostly for testing. Increase snapshot len parameter > provided to pcap_open_live() to accept packet more then 4096 (support > jumbo frames for pcap pmd). Hi, Thanks for the submission. There is already an existing patch for jumbo frame support in the PCAP pmd. http://dpdk.org/dev/patchwork/patch/3792/ Could you review/try that and see if it is suitable for your purposes. Regards, John. --=20 >=20 > Signed-off-by: Maxim Uvarov > --- > lib/librte_pmd_pcap/rte_eth_pcap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/lib/librte_pmd_pcap/rte_eth_pcap.c > b/lib/librte_pmd_pcap/rte_eth_pcap.c > index eebe768..978c137 100644 > --- a/lib/librte_pmd_pcap/rte_eth_pcap.c > +++ b/lib/librte_pmd_pcap/rte_eth_pcap.c > @@ -47,7 +47,6 @@ > #include >=20 > #define RTE_ETH_PCAP_SNAPSHOT_LEN 65535 -#define RTE_ETH_PCAP_SNAPLEN > 4096 #define RTE_ETH_PCAP_PROMISC 1 #define RTE_ETH_PCAP_TIMEOUT -1 > #define ETH_PCAP_RX_PCAP_ARG "rx_pcap" > @@ -468,7 +467,7 @@ open_tx_pcap(const char *key __rte_unused, const char > *value, void *extra_args) > */ > static inline int > open_iface_live(const char *iface, pcap_t **pcap) { > - *pcap =3D pcap_open_live(iface, RTE_ETH_PCAP_SNAPLEN, > + *pcap =3D pcap_open_live(iface, RTE_ETH_PCAP_SNAPSHOT_LEN, > RTE_ETH_PCAP_PROMISC, RTE_ETH_PCAP_TIMEOUT, errbuf); >=20 > if (*pcap =3D=3D NULL) { > -- > 1.9.1