From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <john.mcnamara@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 33B925A76
 for <dev@dpdk.org>; Fri, 17 Jul 2015 13:45:14 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga101.jf.intel.com with ESMTP; 17 Jul 2015 04:45:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,495,1432623600"; d="scan'208";a="749263585"
Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159])
 by fmsmga001.fm.intel.com with ESMTP; 17 Jul 2015 04:45:11 -0700
Received: from irsmsx103.ger.corp.intel.com ([169.254.3.216]) by
 IRSMSX104.ger.corp.intel.com ([169.254.5.171]) with mapi id 14.03.0224.002;
 Fri, 17 Jul 2015 12:45:11 +0100
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Neil Horman <nhorman@tuxdriver.com>, Chao Zhu <chaozhu@linux.vnet.ibm.com>
Thread-Topic: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
Thread-Index: AQHQvVZqZR1hms2NmEabJ+zyDXkQXZ3ZJb0AgAARv8CAACV4gIAGFxxw
Date: Fri, 17 Jul 2015 11:45:10 +0000
Message-ID: <B27915DBBA3421428155699D51E4CFE2F6F572@IRSMSX103.ger.corp.intel.com>
References: <1436783185-8279-1-git-send-email-john.mcnamara@intel.com>
 <20150713104218.GB9631@hmsreliant.think-freely.org>
 <B27915DBBA3421428155699D51E4CFE2F6B3FA@IRSMSX103.ger.corp.intel.com>
 <20150713135955.GC9631@hmsreliant.think-freely.org>
In-Reply-To: <20150713135955.GC9631@hmsreliant.think-freely.org>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Jul 2015 11:45:14 -0000

> -----Original Message-----
> From: Neil Horman [mailto:nhorman@tuxdriver.com]
> Sent: Monday, July 13, 2015 3:00 PM
> To: Mcnamara, John
> Cc: dev@dpdk.org; vladz@cloudius-systems.com
> Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code
>=20
> > > > -		dev_started : 1;   /**< Device state: STARTED(1) / STOPPED(0). *=
/
> > > > +		dev_started : 1,   /**< Device state: STARTED(1) / STOPPED(0). *=
/
> > > > +		lro         : 1;   /**< RX LRO is ON(1) / OFF(0) */
> > > >
> > > >
> >
> Thank you, I'll ack as soon as Chao confirms its not a problem on ppc Nei=
l

Hi,

Just pinging Chao Zhu on this again so that it isn't forgotten.

Neil, just to be clear, are you looking for a validate-abi.sh check on PPC?

Just for context, the lro flag doesn't seem to be used anywhere that would =
be affected by endianness:

    $ ag -w "\->lro"            =20
    drivers/net/ixgbe/ixgbe_rxtx.c
    3767:   if (dev->data->lro) {
    3967:   dev->data->lro =3D 1;

    drivers/net/ixgbe/ixgbe_ethdev.c
    1689:   dev->data->lro =3D 0;

John.
--=20