From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (unknown [45.249.212.255]) by dpdk.org (Postfix) with ESMTP id A49825B1C for ; Wed, 21 Mar 2018 02:45:16 +0100 (CET) Received: from DGGEMM403-HUB.china.huawei.com (unknown [172.30.72.54]) by Forcepoint Email with ESMTP id 88ACD8BD980FB; Wed, 21 Mar 2018 09:45:12 +0800 (CST) Received: from DGGEMM423-HUB.china.huawei.com (10.1.198.40) by DGGEMM403-HUB.china.huawei.com (10.3.20.211) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 21 Mar 2018 09:44:58 +0800 Received: from DGGEMM505-MBS.china.huawei.com ([169.254.2.114]) by dggemm423-hub.china.huawei.com ([10.1.198.40]) with mapi id 14.03.0361.001; Wed, 21 Mar 2018 09:44:46 +0800 From: "Zhoujian (jay)" To: "dev@dpdk.org" CC: "pablo.de.lara.guarch@intel.com" , "roy.fan.zhang@intel.com" , "thomas@monjalon.net" , "Gonglei (Arei)" , "xin.zeng@intel.com" , "Huangweidong (C)" , "wangxin (U)" , longpeng Thread-Topic: [PATCH v2 0/7] crypto: add virtio poll mode driver Thread-Index: AQHTrXGFxmetMvI2IE+gUjok5Wo0sKPaEKZQ Date: Wed, 21 Mar 2018 01:44:46 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.177.19.14] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v2 0/7] crypto: add virtio poll mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 01:45:17 -0000 Gentle ping... > -----Original Message----- > From: Zhoujian (jay) > Sent: Saturday, February 24, 2018 9:14 PM > To: dev@dpdk.org > Cc: pablo.de.lara.guarch@intel.com; roy.fan.zhang@intel.com; > thomas@monjalon.net; Gonglei (Arei) ; > xin.zeng@intel.com; Huangweidong (C) ; wangxin = (U) > ; longpeng ; Zhoujian (= jay) > > Subject: [PATCH v2 0/7] crypto: add virtio poll mode driver >=20 > This patch series introduce virtio crypto poll mode driver. >=20 > Since it is limited by the backend of the virtio-crypto, this patch serie= s > only supports a limited subset of crypto services. > Only the following algorithms are tested: >=20 > Cipher algorithms: > - RTE_CRYPTO_CIPHER_AES_CBC (128-bit, 192-bit and 256-bit keys) > - RTE_CRYPTO_CIPHER_AES_CTR (128-bit, 192-bit and 256-bit keys) >=20 > Firstly build QEMU with libgcrypt cryptography support. > QEMU can then be started using the following parameters: > qemu-system-x86_64 \ > [...] \ > -object cryptodev-backend-builtin,id=3Dcryptodev0 \ > -device virtio-crypto-pci,id=3Dcrypto0,cryptodev=3Dcryptodev0 \ > [...] >=20 > Bind the uio_generic driver for the virtio-crypto device. > For example, 0000:00:04.0 is the domain, bus, device and function number = of > the virtio-crypto device: > modprobe uio_pci_generic > echo -n 0000:00:04.0 > /sys/bus/pci/drivers/virtio-pci/unbind > echo "1af4 1054" > /sys/bus/pci/drivers/uio_pci_generic/new_id >=20 > The front-end virtio crypto PMD driver can be installed: > cd to the top-level DPDK directory > sed -i 's,\(CONFIG_RTE_LIBRTE_PMD_VIRTIO_CRYPTO\)=3Dn,\1=3Dy,' > config/common_base > make config T=3Dx86_64-native-linuxapp-gcc > make install T=3Dx86_64-native-linuxapp-gcc >=20 > The test cases can be compiled as below: > cd to the top-level DPDK directory > export RTE_TARGET=3Dx86_64-native-linuxapp-gcc > export RTE_SDK=3D`pwd` > cd to test/test > make > ./test (MUST reserve enough huge pages memory) > type the command "cryptodev_virtio_autotest" to test >=20 > The result should be like this: > RTE>>cryptodev_virtio_autotest > + ------------------------------------------------------- + + Test Suit= e : > Crypto VIRTIO Unit Test Suite + ----------------------------------------= ---- > ----------- + > 0) TestCase AES-128-CBC Encryption PASS > 1) TestCase AES-128-CBC Decryption PASS > 2) TestCase AES-192-CBC Encryption PASS > 3) TestCase AES-192-CBC Decryption PASS > 4) TestCase AES-256-CBC Encryption PASS > 5) TestCase AES-256-CBC Decryption PASS > 6) TestCase AES-256-CBC OOP Encryption PASS > 7) TestCase AES-256-CBC OOP Decryption PASS > 8) TestCase AES-128-CTR Encryption PASS > 9) TestCase AES-128-CTR Decryption PASS > 10) TestCase AES-192-CTR Encryption PASS > 11) TestCase AES-192-CTR Decryption PASS > 12) TestCase AES-256-CTR Encryption PASS > 13) TestCase AES-256-CTR Decryption PASS + TestCase [ 0] : > test_AES_cipheronly_virtio_all succeeded + -----------------------------= ---- > ---------------------- + + Test Suite Summary > + Tests Total : 1 > + Tests Skipped : 0 > + Tests Executed : 1 > + Tests Unsupported: 0 > + Tests Passed : 1 > + Tests Failed : 0 > + ------------------------------------------------------- + Test OK >=20 > Please help to review, thanks! >=20 > Changes in v2: > - using pre-allocated mempool instead of rte_malloc to improve performan= ce > [Fan] > - split the patch into a patchset [Fan] > - using linux/virtio_crypto.h instead of creating a copy of the file [Fa= n] > - update doc/guides/cryptodevs for describing virtio crypto PMD [Fan] > - update copyright > - delete virtio legacy mode code since virtio-crypto conforms to virtio-= 1.0 > - refine the function and variable names > - fix errors and warnings reported by checkpatch >=20 > Jay Zhou (7): > crypto/virtio: add virtio related fundamental functions > crpyto/virtio: add crypto related session structure > cryptodev/virtio: core code of crypto devices > crypto/virtio: add makefile > cryptodev: add document for virtio crypto PMD > cryptodev: add function tests for virtio crypto PMD > MAINTAINERS: add myself as virtio crypto PMD maintainer >=20 > MAINTAINERS | 6 + > config/common_base | 20 + > doc/guides/cryptodevs/features/virtio.ini | 20 + > doc/guides/cryptodevs/virtio.rst | 93 ++ > drivers/crypto/Makefile | 1 + > drivers/crypto/virtio/Makefile | 31 + > .../virtio/rte_pmd_virtio_crypto_version.map | 3 + > drivers/crypto/virtio/virtio_crypto_algs.h | 27 + > drivers/crypto/virtio/virtio_cryptodev.c | 1544 > ++++++++++++++++++++ > drivers/crypto/virtio/virtio_cryptodev.h | 66 + > drivers/crypto/virtio/virtio_logs.h | 47 + > drivers/crypto/virtio/virtio_pci.c | 460 ++++++ > drivers/crypto/virtio/virtio_pci.h | 252 ++++ > drivers/crypto/virtio/virtio_ring.h | 137 ++ > drivers/crypto/virtio/virtio_rxtx.c | 533 +++++++ > drivers/crypto/virtio/virtqueue.c | 43 + > drivers/crypto/virtio/virtqueue.h | 176 +++ > mk/rte.app.mk | 1 + > test/test/test_cryptodev.c | 49 + > test/test/test_cryptodev.h | 1 + > test/test/test_cryptodev_aes_test_vectors.h | 45 +- > test/test/test_cryptodev_blockcipher.c | 9 +- > test/test/test_cryptodev_blockcipher.h | 1 + > 23 files changed, 3549 insertions(+), 16 deletions(-) create mode 10064= 4 > doc/guides/cryptodevs/features/virtio.ini > create mode 100644 doc/guides/cryptodevs/virtio.rst create mode 100644 > drivers/crypto/virtio/Makefile create mode 100644 > drivers/crypto/virtio/rte_pmd_virtio_crypto_version.map > create mode 100644 drivers/crypto/virtio/virtio_crypto_algs.h > create mode 100644 drivers/crypto/virtio/virtio_cryptodev.c > create mode 100644 drivers/crypto/virtio/virtio_cryptodev.h > create mode 100644 drivers/crypto/virtio/virtio_logs.h > create mode 100644 drivers/crypto/virtio/virtio_pci.c > create mode 100644 drivers/crypto/virtio/virtio_pci.h > create mode 100644 drivers/crypto/virtio/virtio_ring.h > create mode 100644 drivers/crypto/virtio/virtio_rxtx.c > create mode 100644 drivers/crypto/virtio/virtqueue.c create mode 100644 > drivers/crypto/virtio/virtqueue.h >=20 > -- > 1.8.3.1 >=20