Re: [dpdk-dev] [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices

["Zhoujian (jay)" <jianjay.zhou@huawei.com>]

Hi Fan,

Really thank for your response and testing!

> -----Original Message-----
> From: Zhang, Roy Fan [mailto:roy.fan.zhang@intel.com]
> Sent: Wednesday, March 21, 2018 12:09 PM
> To: Zhoujian (jay) <jianjay.zhou@huawei.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> thomas@monjalon.net; Gonglei (Arei) <arei.gonglei@huawei.com>; Zeng, Xin
> <xin.zeng@intel.com>; Huangweidong (C) <weidong.huang@huawei.com>; wangxin (U)
> <wangxinxin.wang@huawei.com>; longpeng <longpeng2@huawei.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>
> Subject: RE: [PATCH v2 3/7] cryptodev/virtio: core code of crypto devices
> 
> Hi Jay,
> 
> Excellent work! The patch, although need some minor rework, has improved the
> performance.
> Some comments:
> 
> 1. you need to set up capabilities for virtio_crypto PMD. As in Qemu vhost
> crypto proxy backend only AESCBC and SHA1 are supported (in
> cryptodev_vhost_user_init() definition), I believe in this version these two
> algorithms shall be enough.  Actually for the same reason I suggest you to
> remove all AES_CTR test cases in the virtio_crypto PMD functional test, as
> they will fail when vhost_user crypto backend is used.
> 
> You may use driver/crypto/qat/qat_crypto_capabilities.h as example. The const
> capabilities array shall be returned to the application when
> virtio_crypto_dev_info_get() is called.

Okay. Thank for your suggestion.

> 2. there is a bug in virtio_crypto_queue_setup(), you declared " uint32_t i,
> j;" while i may be used uninitialized later.

Maybe the compiled result is different using different GCC, but will fix then.

Regards,
Jay

> 
> Regards,
> Fan
> 
> > diff --git a/drivers/crypto/virtio/virtio_rxtx.c
> > b/drivers/crypto/virtio/virtio_rxtx.c
> > new file mode 100644
> > index 0000000..b7d8066
> > --- /dev/null
> > +++ b/drivers/crypto/virtio/virtio_rxtx.c
> > @@ -0,0 +1,533 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright(c) 2018 HUAWEI TECHNOLOGIES CO., LTD.
> > + */
> > +