From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 067ABA2F6B for ; Tue, 8 Oct 2019 04:03:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D0FA91C011; Tue, 8 Oct 2019 04:03:36 +0200 (CEST) Received: from huawei.com (szxga01-in.huawei.com [45.249.212.187]) by dpdk.org (Postfix) with ESMTP id 991B12986 for ; Tue, 8 Oct 2019 04:03:35 +0200 (CEST) Received: from DGGEMM405-HUB.china.huawei.com (unknown [172.30.72.57]) by Forcepoint Email with ESMTP id 105BEE15AB8A014362D6; Tue, 8 Oct 2019 10:03:34 +0800 (CST) Received: from DGGEMM423-HUB.china.huawei.com (10.1.198.40) by DGGEMM405-HUB.china.huawei.com (10.3.20.213) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 8 Oct 2019 10:03:33 +0800 Received: from DGGEMM528-MBX.china.huawei.com ([169.254.8.235]) by dggemm423-hub.china.huawei.com ([10.1.198.40]) with mapi id 14.03.0439.000; Tue, 8 Oct 2019 10:03:25 +0800 From: "Zhoujian (jay)" To: Xiao Wang CC: "dev@dpdk.org" , Akhil Goyal , "Huangweidong (C)" Thread-Topic: [PATCH] crypto/virtio: alloc private data by NUMA affinity Thread-Index: AQHVYyaM8T0pBMJDZEG8a1QXYXWzm6dQMl6A Date: Tue, 8 Oct 2019 02:03:24 +0000 Message-ID: References: <20190904132151.58885-1-xiao.w.wang@intel.com> In-Reply-To: <20190904132151.58885-1-xiao.w.wang@intel.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.133.205.84] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] crypto/virtio: alloc private data by NUMA affinity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xiao Wang [mailto:xiao.w.wang@intel.com] > Sent: Wednesday, September 4, 2019 9:22 PM > To: Zhoujian (jay) > Cc: dev@dpdk.org; Xiao Wang > Subject: [PATCH] crypto/virtio: alloc private data by NUMA affinity >=20 > It's better to allocate device private data on the same NUMA node with de= vice, > rather than with the main thread. This helps avoid cross-NUMA access for > worker thread. >=20 > Signed-off-by: Xiao Wang Reviewed-by: Jay Zhou > --- > drivers/crypto/virtio/virtio_cryptodev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/crypto/virtio/virtio_cryptodev.c > b/drivers/crypto/virtio/virtio_cryptodev.c > index f16bdfe57..4af479f54 100644 > --- a/drivers/crypto/virtio/virtio_cryptodev.c > +++ b/drivers/crypto/virtio/virtio_cryptodev.c > @@ -1441,7 +1441,7 @@ crypto_virtio_pci_probe( { > struct rte_cryptodev_pmd_init_params init_params =3D { > .name =3D "", > - .socket_id =3D rte_socket_id(), > + .socket_id =3D pci_dev->device.numa_node, > .private_data_size =3D sizeof(struct virtio_crypto_hw) > }; > char name[RTE_CRYPTODEV_NAME_MAX_LEN]; > -- > 2.15.1