From: Andrew Boyer <aboyer@pensando.io>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Alfredo Cardigliano <cardigliano@ntop.org>,
ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] net: redefine array size macros
Date: Mon, 1 Feb 2021 17:32:00 -0500 [thread overview]
Message-ID: <B523CC8C-C537-4616-A71D-D30465901075@pensando.io> (raw)
In-Reply-To: <4842644.BW4ZEuPtVA@thomas>
> On Feb 1, 2021, at 5:28 PM, Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 29/01/2021 23:44, Andrew Boyer:
>> Replace copies of size(arr)/size(arr[0]) with RTE_DIM().
>> Eventually all of these macro definitions should be removed.
>>
>> Signed-off-by: Andrew Boyer <aboyer@pensando.io>
>> ---
>> drivers/net/atlantic/atl_hw_regs.h | 2 +-
>> drivers/net/axgbe/axgbe_common.h | 2 +-
>> drivers/net/bnx2x/bnx2x.h | 2 +-
>> drivers/net/bnx2x/elink.h | 2 +-
>> drivers/net/ena/ena_ethdev.c | 2 +-
>> drivers/net/enic/base/vnic_devcmd.h | 2 +-
>> drivers/net/hns3/hns3_ethdev.h | 2 +-
>> drivers/net/i40e/base/i40e_osdep.h | 2 +-
>> drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 2 +-
>> drivers/net/thunderx/base/nicvf_hw.h | 2 +-
>> 10 files changed, 10 insertions(+), 10 deletions(-)
>
> Thanks for the cleanup.
>
> In the title, the prefix "net" means librte_net.
> Here, it should be "drivers/net". I know it's confusing :)
>
> Please check other patches in the series,
> they are versioned as v2 and numbered 4/13 and 6/13.
Thank you for the review - do you want me to resend or can you fix it up yourself?
The 4/13 and 6/13 are fixups that Ferruh asked for, while he applied the rest of the series. I made the 4/13 a v2 replying to the original 4/13 and the 6/13 a v2 replying to the original 6/13. If I messed it up, my apologies!
-Andrew
next prev parent reply other threads:[~2021-02-01 22:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 22:44 Andrew Boyer
2021-02-01 22:28 ` Thomas Monjalon
2021-02-01 22:32 ` Andrew Boyer [this message]
2021-02-02 12:30 ` Ferruh Yigit
2021-02-22 17:09 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2021-01-18 20:34 [dpdk-dev] [PATCH 00/13] net/ionic: fixes and optimizations Andrew Boyer
2021-01-18 20:34 ` [dpdk-dev] [PATCH 01/13] net/ionic: strip out unneeded interrupt code Andrew Boyer
2021-01-18 20:34 ` [dpdk-dev] [PATCH 02/13] net/ionic: observe endianness in firmware commands Andrew Boyer
2021-01-18 20:34 ` [dpdk-dev] [PATCH 03/13] net/ionic: observe endianness in Rx filter code Andrew Boyer
2021-01-18 20:34 ` [dpdk-dev] [PATCH 04/13] net/ionic: add an array-size macro Andrew Boyer
2021-01-27 17:22 ` Ferruh Yigit
2021-01-27 17:40 ` Andrew Boyer
2021-01-29 22:44 ` [dpdk-dev] [PATCH v2 4/13] net/ionic: use the existing " Andrew Boyer
2021-02-02 12:45 ` Ferruh Yigit
2021-01-18 20:35 ` [dpdk-dev] [PATCH 05/13] net/ionic: query firmware for supported queue versions Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 06/13] net/ionic: clean up Tx queue version support Andrew Boyer
2021-01-27 17:30 ` Ferruh Yigit
2021-01-27 17:46 ` Andrew Boyer
2021-01-29 22:44 ` [dpdk-dev] [PATCH v2 6/13] " Andrew Boyer
2021-02-02 12:46 ` Ferruh Yigit
2021-02-05 20:20 ` Thomas Monjalon
2021-02-05 20:26 ` Andrew Boyer
2021-02-05 20:34 ` Thomas Monjalon
2021-01-18 20:35 ` [dpdk-dev] [PATCH 07/13] net/ionic: inline queue flush function Andrew Boyer
2021-01-27 17:36 ` Ferruh Yigit
2021-01-27 17:43 ` Andrew Boyer
2021-01-27 17:50 ` Ferruh Yigit
2021-01-18 20:35 ` [dpdk-dev] [PATCH 08/13] net/ionic: inline queue space function Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 09/13] net/ionic: observe endiannness in ioread/iowrite Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 10/13] net/ionic: fix to allow separate L3 and L4 csum offload Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 11/13] net/ionic: convert per-queue offloads into queue flags Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 12/13] net/ionic: fix up function attribute tags Andrew Boyer
2021-01-18 20:35 ` [dpdk-dev] [PATCH 13/13] net/ionic: fix address handling in transmit code Andrew Boyer
2021-01-27 18:02 ` [dpdk-dev] [PATCH 00/13] net/ionic: fixes and optimizations Ferruh Yigit
2021-01-27 18:10 ` Andrew Boyer
2021-01-27 22:23 ` Ferruh Yigit
2021-01-27 22:25 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B523CC8C-C537-4616-A71D-D30465901075@pensando.io \
--to=aboyer@pensando.io \
--cc=cardigliano@ntop.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).