From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C5F4A0A0B; Mon, 1 Feb 2021 23:32:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DB1E160688; Mon, 1 Feb 2021 23:32:06 +0100 (CET) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 5152E16067B for ; Mon, 1 Feb 2021 23:32:04 +0100 (CET) Received: by mail-pg1-f173.google.com with SMTP id n10so13080295pgl.10 for ; Mon, 01 Feb 2021 14:32:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=5l9OzVG4/bcleaqm0lqVoXF7cO1nb50O+6fJ5UZGnYY=; b=mEw+OrFsl+Shn3kwa8OCaxtTnPNVNWrqz/9obt2dJjrcaq79qk3eLdHKgigVO+5f0l 06FLdgxP7rQhiIvor93MMadQGIH2n6ukoT/BTH40LiFTohpJouIZh5h/tjA9RiueWza0 O8VMB2eOd2cQKth6VVZLBdfJgvXcHsxUxWzxwhmk79Vp2ZMAKUdBBSGsErjVKrwSei5l SqbE5bowvuP1+DTnHspCF1i1KxAYggigyK4ZfSf7kh0Pw+xXiGP3f7tKsC/vaxhLElOp 3VFSiDxw+wHiePWq/lFyXJJsUaQFVrjuOhF/0b8lVliYe+f3duGlAt4/fQ9LXKpTxTkx GFug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=5l9OzVG4/bcleaqm0lqVoXF7cO1nb50O+6fJ5UZGnYY=; b=GzZNxy18jXDfh77vIWcmPzsTwU8pmdtPmC48GmcC7HU1GgkC25zkZt86N8BgwnFyy2 ACojvaxHgE4d3U2Rb5FUhmIb5w7HImGOMp6u4cq0NIF1Tv3oCPvRtNMkRP2xyP1Xbtgf CFbd4hPrm1ZwDW0dULvc2/w4+T/kzOXdTFsQyBiq7TqFE+SJQsk0CFWILjoUHa7utYBu WhbH8h64oKHU45wofN16i2OpQkfceLdhvHNZoyEBnZwLjFUFvHvC9NAunhArBn38mES6 MsF4KAfstUFsgyEyDF2T8fcaUxRqxysGJYx1RF6Y3eMeX7idPJStGrqL5XzvpGqxPYwl Q8Dg== X-Gm-Message-State: AOAM531yh3jFgi28BGceBu4Erfm4i2LvUkY+fmjwqQjTYp8SbJGADhWG BS2HGn6CD8wYj6MGPuqlnyeouw== X-Google-Smtp-Source: ABdhPJxcCIwO6noi88Jqq2YHXo8PxFlsarBcI+PtRW0qSFMWiXqGUmX2Wk+d4lpvTswOFCt8DEKnuw== X-Received: by 2002:a65:47c7:: with SMTP id f7mr18781466pgs.305.1612218723538; Mon, 01 Feb 2021 14:32:03 -0800 (PST) Received: from ?IPv6:2600:1700:6b0:fde0:8014:afb0:bfce:24e4? ([2600:1700:6b0:fde0:8014:afb0:bfce:24e4]) by smtp.gmail.com with ESMTPSA id u12sm18865937pgi.91.2021.02.01.14.32.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Feb 2021 14:32:03 -0800 (PST) From: Andrew Boyer Message-Id: Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Date: Mon, 1 Feb 2021 17:32:00 -0500 In-Reply-To: <4842644.BW4ZEuPtVA@thomas> Cc: dev , Alfredo Cardigliano , ferruh.yigit@intel.com To: Thomas Monjalon References: <20210129224434.71536-1-aboyer@pensando.io> <4842644.BW4ZEuPtVA@thomas> X-Mailer: Apple Mail (2.3608.120.23.2.4) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net: redefine array size macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Feb 1, 2021, at 5:28 PM, Thomas Monjalon = wrote: >=20 > 29/01/2021 23:44, Andrew Boyer: >> Replace copies of size(arr)/size(arr[0]) with RTE_DIM(). >> Eventually all of these macro definitions should be removed. >>=20 >> Signed-off-by: Andrew Boyer >> --- >> drivers/net/atlantic/atl_hw_regs.h | 2 +- >> drivers/net/axgbe/axgbe_common.h | 2 +- >> drivers/net/bnx2x/bnx2x.h | 2 +- >> drivers/net/bnx2x/elink.h | 2 +- >> drivers/net/ena/ena_ethdev.c | 2 +- >> drivers/net/enic/base/vnic_devcmd.h | 2 +- >> drivers/net/hns3/hns3_ethdev.h | 2 +- >> drivers/net/i40e/base/i40e_osdep.h | 2 +- >> drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 2 +- >> drivers/net/thunderx/base/nicvf_hw.h | 2 +- >> 10 files changed, 10 insertions(+), 10 deletions(-) >=20 > Thanks for the cleanup. >=20 > In the title, the prefix "net" means librte_net. > Here, it should be "drivers/net". I know it's confusing :) >=20 > Please check other patches in the series, > they are versioned as v2 and numbered 4/13 and 6/13. Thank you for the review - do you want me to resend or can you fix it up = yourself? The 4/13 and 6/13 are fixups that Ferruh asked for, while he applied the = rest of the series. I made the 4/13 a v2 replying to the original 4/13 = and the 6/13 a v2 replying to the original 6/13. If I messed it up, my = apologies! -Andrew=