From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1821EC300 for ; Tue, 2 Jun 2015 15:15:02 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 02 Jun 2015 06:15:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,539,1427785200"; d="scan'208";a="580633135" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga003.jf.intel.com with ESMTP; 02 Jun 2015 06:15:01 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 2 Jun 2015 06:15:01 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by ORSMSX152.amr.corp.intel.com (10.22.226.39) with Microsoft SMTP Server (TLS) id 14.3.224.2; Tue, 2 Jun 2015 06:15:01 -0700 Received: from FMSMSX110.amr.corp.intel.com ([169.254.14.46]) by fmsmsx120.amr.corp.intel.com ([169.254.15.202]) with mapi id 14.03.0224.002; Tue, 2 Jun 2015 06:15:00 -0700 From: "Wang, Liang-min" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Thread-Index: AQHQmkV0vh50QuHJo0WVOZnDigauCp2ZosAA//+RahA= Date: Tue, 2 Jun 2015 13:15:00 +0000 Message-ID: References: <1432927612-12244-1-git-send-email-liang-min.wang@intel.com> <1432927612-12244-3-git-send-email-liang-min.wang@intel.com> <2827467.MLJnnY93Dx@xps13> In-Reply-To: <2827467.MLJnnY93Dx@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Jun 2015 13:15:03 -0000 >2015-05-29 15:26, Liang-Min Larry Wang: >> adding a new library based upon ethdev APIs to provide API's that bear=20 >> the same functionality as ethtool_ops (linux/ethtool.h) and=20 >> net_device_ops (linux/netdevice.h). >>=20 >> Signed-off-by: Liang-Min Larry Wang >> --- >> MAINTAINERS | 4 + >> config/common_linuxapp | 5 + >> lib/Makefile | 1 + >> lib/librte_ethtool/Makefile | 56 +++++++ >> lib/librte_ethtool/rte_ethtool.c | 155 +++++++++++++++++ >> lib/librte_ethtool/rte_ethtool.h | 257 ++++++++++++++++++++++= +++++++ >> lib/librte_ethtool/rte_ethtool_version.map | 18 ++ >> mk/rte.app.mk | 1 + > >NACK for several reasons: >- It's unclear what benefits this ethdev wrapper is bringing Since ethtool is provided to assist users migrating from kernel ethtool/net= _device_op based design to user-space DPDK device management. The ethtool A= PI's are created to closely maintain its original interface, therefore this= library depends on . To avoid pollute the existing ethdev = interface, a new library is created. To minimize code replication and maint= ain closely 1:1 API definition with kernel space API, this interface is des= igned based upon available ethdev APIs and add additional dev_ops if it's n= ecessary. >- There is no obvious interest (how is it supposed to be used?) There are already two acknowledge on this release. Earlier comment on this = patch has that " ... The API's for ethtool like things are valuable ..." >- There is no update in the doc/ directory Need more guidance on that. >Other comments: >- the patches are not versioned There is version file. Not sure what do you mean "the patches are not versi= oned" >- the copyright starts in 2010 Will fix that. >I'm curious to understand how renaming rte_eth_dev_set_mtu() to >rte_ethtool_net_change_mtu() will help anyone. As described, this interface is designed to provide API closely to kernel s= pace ethtool ops and net_device_op.