From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id DF2A15A99 for ; Sat, 27 Jun 2015 03:21:53 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 26 Jun 2015 18:21:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,687,1427785200"; d="scan'208";a="718475583" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga001.jf.intel.com with ESMTP; 26 Jun 2015 18:21:52 -0700 Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 26 Jun 2015 18:21:52 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by ORSMSX112.amr.corp.intel.com (10.22.240.13) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 26 Jun 2015 18:21:52 -0700 Received: from FMSMSX110.amr.corp.intel.com ([169.254.14.199]) by FMSMSX155.amr.corp.intel.com ([169.254.5.203]) with mapi id 14.03.0224.002; Fri, 26 Jun 2015 18:21:52 -0700 From: "Wang, Liang-min" To: Stephen Hemminger Thread-Topic: [dpdk-dev] [PATCH v8 1/5] ethdev: add apis to support access device info Thread-Index: AQHQsBwzt/YjESx1tEy8AsSzuIc6j52/dfQAgAAY8JA= Date: Sat, 27 Jun 2015 01:21:50 +0000 Message-ID: References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com> <1435328807-15788-1-git-send-email-liang-min.wang@intel.com> <1435328807-15788-2-git-send-email-liang-min.wang@intel.com> <20150626095158.4725a924@urahara> In-Reply-To: <20150626095158.4725a924@urahara> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v8 1/5] ethdev: add apis to support access device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jun 2015 01:21:54 -0000 > -----Original Message----- > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > Sent: Friday, June 26, 2015 12:52 PM > To: Wang, Liang-min > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 1/5] ethdev: add apis to support access > device info >=20 > On Fri, 26 Jun 2015 10:26:43 -0400 > Liang-Min Larry Wang wrote: >=20 > > add new apis: > > - rte_eth_dev_default_mac_addr_set > > - rte_eth_dev_reg_length > > - rte_eth_dev_reg_info > > - rte_eth_dev_eeprom_length > > - rte_eth_dev_get_eeprom > > - rte_eth_dev_set_eeprom > > > > to enable reading device parameters (mac-addr, register, > > eeprom) based upon ethtool alike > > data parameter specification. > > > > Signed-off-by: Liang-Min Larry Wang >=20 > I agree in principal, but has lots of style issues (see report from check= patch). >=20 > ERROR: spaces required around that '=3D' (ctx:VxW) > #193: FILE: lib/librte_ether/rte_ethdev.c:3677: > + if ((dev=3D &rte_eth_devices[port_id]) =3D=3D NULL) { > ^ >=20 > ERROR: do not use assignment in if condition > #193: FILE: lib/librte_ether/rte_ethdev.c:3677: > + if ((dev=3D &rte_eth_devices[port_id]) =3D=3D NULL) { >=20 > ERROR: spaces required around that '=3D' (ctx:VxW) > #213: FILE: lib/librte_ether/rte_ethdev.c:3697: > + if ((dev=3D &rte_eth_devices[port_id]) =3D=3D NULL) { > ^ >=20 > ERROR: do not use assignment in if condition > #213: FILE: lib/librte_ether/rte_ethdev.c:3697: > + if ((dev=3D &rte_eth_devices[port_id]) =3D=3D NULL) { >=20 > ERROR: spaces required around that '=3D' (ctx:VxW) > #232: FILE: lib/librte_ether/rte_ethdev.c:3716: > + if ((dev=3D &rte_eth_devices[port_id]) =3D=3D NULL) { > ^ >=20 > ERROR: do not use assignment in if condition > #232: FILE: lib/librte_ether/rte_ethdev.c:3716: > + if ((dev=3D &rte_eth_devices[port_id]) =3D=3D NULL) { >=20 > ERROR: spaces required around that '=3D' (ctx:VxW) > #251: FILE: lib/librte_ether/rte_ethdev.c:3735: > + if ((dev=3D &rte_eth_devices[port_id]) =3D=3D NULL) { > ^ >=20 > ERROR: do not use assignment in if condition > #251: FILE: lib/librte_ether/rte_ethdev.c:3735: > + if ((dev=3D &rte_eth_devices[port_id]) =3D=3D NULL) { >=20 > ERROR: spaces required around that '=3D' (ctx:VxW) > #270: FILE: lib/librte_ether/rte_ethdev.c:3754: > + if ((dev=3D &rte_eth_devices[port_id]) =3D=3D NULL) { > ^ >=20 > ERROR: do not use assignment in if condition > #270: FILE: lib/librte_ether/rte_ethdev.c:3754: > + if ((dev=3D &rte_eth_devices[port_id]) =3D=3D NULL) { Issues addressed over v9.