From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <liang-min.wang@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id EFABECA6E
 for <dev@dpdk.org>; Sat, 27 Jun 2015 04:37:37 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 26 Jun 2015 19:37:34 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,687,1427785200"; d="scan'208";a="718494640"
Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128])
 by orsmga001.jf.intel.com with ESMTP; 26 Jun 2015 19:37:33 -0700
Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by
 ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Fri, 26 Jun 2015 19:37:33 -0700
Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by
 ORSMSX162.amr.corp.intel.com (10.22.240.85) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Fri, 26 Jun 2015 19:37:33 -0700
Received: from FMSMSX110.amr.corp.intel.com ([169.254.14.199]) by
 FMSMSX112.amr.corp.intel.com ([10.18.116.6]) with mapi id 14.03.0224.002;
 Fri, 26 Jun 2015 19:37:33 -0700
From: "Wang, Liang-min" <liang-min.wang@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Thread-Topic: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops
Thread-Index: AQHQsHdNltaETzYkh0W6/WEMw2fQ3p3ABsMA//+cq8A=
Date: Sat, 27 Jun 2015 02:37:32 +0000
Message-ID: <B6CB929FEBC10D4FAC4BCA7EF2298E2571779D48@FMSMSX110.amr.corp.intel.com>
References: <1432946276-9424-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-1-git-send-email-liang-min.wang@intel.com>
 <1435367948-20240-3-git-send-email-liang-min.wang@intel.com>
 <20150626183248.44a55e34@urahara>
In-Reply-To: <20150626183248.44a55e34@urahara>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.1.200.107]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool ops
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Jun 2015 02:37:40 -0000



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, June 26, 2015 9:33 PM
> To: Wang, Liang-min
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v9 2/5] ixgbe: add ops to support ethtool =
ops
>=20
> On Fri, 26 Jun 2015 21:19:05 -0400
> Liang-Min Larry Wang <liang-min.wang@intel.com> wrote:
>=20
> > +static int
> > +ixgbe_get_reg_length(struct rte_eth_dev *dev __rte_unused)
> > +{
> > +	struct ixgbe_hw *hw =3D IXGBE_DEV_PRIVATE_TO_HW(dev->data-
> >dev_private)
>=20
> The dev arg is used, and therefore should not be marked __rte_unused.

Fixed at v10.